chore(deps): update to Theia 1.42.1
#2246
Conversation
kittaakos
added
type: enhancement
kittaakos
added
topic: security
- update translation VSIXs to `1.81.0` - revert eclipse-theia/theia#12867 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos
force-pushed
the
theia-1.42.0
branch
from
fe416be
to
4663207
Compare
kittaakos
removed
status: on hold
There was a problem hiding this comment.
Internationalization lost for some menu items
To reproduce
- Select File > Preferences from the Arduino IDE menus.
- Select a language other than English from the "Language" menu.
- Open the <edit> menu.
(where <edit> is the localized name for the peek menu item)
🐛 The following menu items are not localized:- Undo
- Redo
- Cut
- Copy
- Paste
- Select All
- Right click on the editor view.
🐛 The following menu items are not localized:- Redo
- Undo
- Cut
- Copy
- Paste
Expected behavior
All strings exposed in the Arduino IDE UI are internationalized
Arduino IDE version
133ff30 (tester build for 4663207)
Operating system
Windows 11
Additional context
The fault is not present when using the latest build from the main branch (69b7365)
Maybe caused by eclipse-theia/theia#12951
Related: #2213
Since we seem to experience this type of regression regularly (made more likely since breaking changes are made to the API of the VS Code language pack without making a major version bump as would be required for semver-compliance), it would be very useful to find a way for the CI system to catch it.
The Theia code knows when there is no localization data for an i18n key (which should always indicate a bug):
but it doesn't make that information available.
OK. Let's find an automated solution for this problem. |
There was a problem hiding this comment.
Compile operations can't be triggered
Describe the problem
Triggering any of the following operations has no effect:
- Verify/Compile
- Upload
- Upload Using Programmer
- Export Compiled Binary
To reproduce
- Select any board from the Tools > Board menu.
- Select Sketch > Verify/Compile from the Arduino IDE menus.
🐛 There is no reaction.
Arduino IDE version
133ff30 (tester build for 4663207)
Operating system
Windows 11
Additional context
The fault is not present when using the latest build from the main branch (69b7365)
Triggering the fault doesn't cause any log output to be produced.
The fault occurs regardless of how the operation is triggered:
- Via the menu items
- Via the toolbar buttons
- Via the command palette
Other operations such as Tools > Burn Bootloader, Library Manager installation, Boards Manager installation do work as expected.
|
We should use https://github.com/eclipse-theia/theia/releases/tag/v1.43.0 instead. |
|
It's obsolete. The next target is 1.46.1 |
Depends on #2252✅Motivation
Use the latest Theia version:
1.42.1.Change description
1.81.0(where available)Other information
IDE2 will automatically get the multi-line search feature from Theia (eclipse-theia/theia#12868):
multiline-search-in-workspace.mp4
I do not expect any other Theia behavioral changes, but here is the diff: eclipse-theia/theia@v1.41.0...v1.42.1. I disabled one undesired new feature (eclipse-theia/theia#12867) from Theia.
Reviewer checklist