Fix bug in TheiaDialog page object
#12753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug with the `TheiaDialog.waitUntilMainButtonIsEnabled` method not working as expected (infinite timeout). Call `waitUntilMainButtonIsEnabled` in `TheiaExplorView.renameNode` to ensure that the method is covered by the test case execution.
planger
approved these changes
Jul 25, 2023
vince-fugnitto
added
ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes a bug with the
TheiaDialog.waitUntilMainButtonIsEnabledmethod not working as expected.Calling the method resulted in an infinite timeout because
thiswas used inside of thepageFunction. ThepageFunctionis executed inside the browser where theTheiaDialogpage objectis not available and therefore it wasundefined.Call
waitUntilMainButtonIsEnabledinTheiaExplorView.renameNodeto ensure that the method is covered by the test case execution.How to test
This change is directly tested by the playwright test suite.
Review checklist
Reminder for reviewers