Fix bug in TheiaDialog page object (#12753)

Fix bug with the `TheiaDialog.waitUntilMainButtonIsEnabled` method not working as expected (infinite timeout). Call `waitUntilMainButtonIsEnabled` in `TheiaExplorView.renameNode` to ensure that the method is covered by the test case execution.
eclipse-theia · Jul 26, 2023 · 0860f57 · 0860f57
1 parent 86567e3
commit 0860f57
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/examples/playwright/src/theia-dialog.ts b/examples/playwright/src/theia-dialog.ts
@@ -105,10 +105,10 @@ export class TheiaDialog extends TheiaPageObject {
     }
 
     async waitUntilMainButtonIsEnabled(): Promise<void> {
-        await this.page.waitForFunction(() => {
-            const button = document.querySelector<HTMLButtonElement>(`${this.controlSelector} > button.theia-button.main`);
+        await this.page.waitForFunction(predicate => {
+            const button = document.querySelector<HTMLButtonElement>(predicate.buttonSelector);
             return !!button && !button.disabled;
-        });
+        }, { buttonSelector: `${this.controlSelector} > button.theia-button.main` });
     }
 
 }
diff --git a/examples/playwright/src/theia-explorer-view.ts b/examples/playwright/src/theia-explorer-view.ts
@@ -265,6 +265,7 @@ export class TheiaExplorerView extends TheiaView {
         const renameDialog = new TheiaRenameDialog(this.app);
         await renameDialog.waitForVisible();
         await renameDialog.enterNewName(newName);
+        await renameDialog.waitUntilMainButtonIsEnabled();
         confirm ? await renameDialog.confirm() : await renameDialog.close();
         await renameDialog.waitForClosed();
         await this.refresh();