Remove extension namespace 'hack' #11931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thegecko <rob.moran@arm.com>
|
@thegecko I don't have any strong opinion to keep the old way, I believe it was originally implemented by RedHat and they required it. |
|
Thanks @vince-fugnitto , perhaps someone from RedHat can confirm if this is OK? |
msujew
reviewed
Dec 5, 2022
thegecko
force-pushed
the
remove-plugins-namespace
branch
from
a8fcb73
to
354b1d7
Compare
thegecko
changed the title
msujew
approved these changes
Dec 5, 2022
Signed-off-by: robmor01 <Rob.Moran@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
As mentioned in #11887 (comment) there is a
hacked inextensions namespace for the node extension host. This is now surplus to requirements so can be removed.How to test
Hopefully nothing should have changed! Testing is the same as #11887
Review checklist
Reminder for reviewers