Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement VS Code extensions namespace #11887

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

thegecko
Copy link
Member

Signed-off-by: thegecko rob.moran@arm.com

What it does

This PR implements the extensions namespace in the VS Code API which is currently marked as not implemented in the comparison coverage report.

The functionality was already implemented, but exposed under the plugins export.

How to test

You can test the extensions onDidChange event by hooking into it in a VS Code extension.
You can test the getExtension function by calling it from a VS Code extension. You can then activate this extension and access the functionality on it using this pattern:

https://github.com/Marus/cortex-debug-db-stm32f4/blob/master/src/extension.ts#L15

Note: access to plugins is currently only possible within the same extensionHost (this matches VS Code functionality)

Review checklist

Reminder for reviewers

Signed-off-by: thegecko <rob.moran@arm.com>
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 I can confirm that the API comparison report marks the API as fully supported.

@thegecko thegecko merged commit 28edcad into eclipse-theia:master Nov 21, 2022
@thegecko thegecko deleted the vscode-extensions-namespace branch November 21, 2022 12:05
@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Nov 24, 2022
@vince-fugnitto vince-fugnitto added this to the 1.32.0 milestone Nov 24, 2022
@tsmaeder
Copy link
Contributor

@thegecko the vscode namespace was implementing the extensions namespace in terms of the plugins namespace in plugin-vscode-init.ts. Shouldn't we remove that "hack" now?

@thegecko
Copy link
Member Author

Good spot, this should probably be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants