Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set focus to another editor if current one is closed #4502

Closed
mmorhun opened this issue Mar 7, 2019 · 2 comments
Closed

Set focus to another editor if current one is closed #4502

mmorhun opened this issue Mar 7, 2019 · 2 comments
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help plug-in system issues related to the plug-in system shell issues related to the core shell vscode issues related to VSCode compatibility

Comments

@mmorhun
Copy link
Contributor

mmorhun commented Mar 7, 2019 •
edited
Loading

Description

When current text editor gets closed, focus isn't set into another one.

This is related to VSCode compatibility in Theia plug-in API.

Reproduction Steps

  1. Open a few editors
  2. Set focus into one
  3. Close active editor tab

Another editor is shown but focus is not there. When typing text, nothing happens.
@mmorhun mmorhun added bug bugs found in the application plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility labels Mar 7, 2019
@mmorhun mmorhun mentioned this issue Mar 7, 2019
Merged
@akosyakov
Copy link
Member

Sounds like it should be generally done on the shell level. If a focused widget is closed in the tab group then new visible widget in the same tab group should be focused. Not sure what should happen if the focused widget was the last, probably a visible widget from next (or first if a tab group was last) tab group should be focused.

@akosyakov akosyakov added the shell issues related to the core shell label Mar 8, 2019
@evidolob evidolob mentioned this issue Apr 19, 2019
Closed
50 tasks
@ashumilova ashumilova mentioned this issue Apr 23, 2019
Closed
25 tasks
@evidolob evidolob mentioned this issue May 6, 2019
Closed
26 tasks
@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Dec 2, 2019
@spoenemann
Copy link
Contributor

Duplicate of #2234

@spoenemann spoenemann marked this as a duplicate of #2234 Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help plug-in system issues related to the plug-in system shell issues related to the core shell vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akosyakov @spoenemann @mmorhun