Fix VScode plug-in API incompatibilities for onDidChangeActiveTextEditor event #4503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor event Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
evidolob
approved these changes
Mar 7, 2019
benoitf
approved these changes
Mar 7, 2019
vitaliy-guliy
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incompatibilities in Theia plug-in API with VSCode:
onDidChangeActiveTextEditorevent withundefinedargument and then with the next editor, if any. However, Theia core doesn't switch focus to the next editor tab when current one is closed. Created issue for this problem.Was done while working on #4218