Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shell] transfer focus to next widget if the focused widget is closed #2234

Closed
MarkZ3 opened this issue Jun 28, 2018 · 2 comments · Fixed by #7707
Closed

[shell] transfer focus to next widget if the focused widget is closed #2234

MarkZ3 opened this issue Jun 28, 2018 · 2 comments · Fixed by #7707
Assignees
@akosyakov
Labels
enhancement issues that are enhancements to current functionality - nice to haves shell issues related to the core shell

Comments

@MarkZ3
Copy link
Contributor

MarkZ3 commented Jun 28, 2018

Using Theia master (8a5132e), browser and electron examples.

  1. Open two files
  2. Close one of the editor (Alt+W or middle click)
  3. The other editor comes on top but has no focus, i.e. you cannot type
@svenefftinge
Copy link
Contributor

It would be good to focus the least recently focussed widget, when the one with focus gets closed.

@dhuebner
Copy link
Member

The most annoying thing is when you do Alt+W again the Files view, or any other currently on top of the left view stack gets closed

@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves editor issues related to the editor labels Nov 12, 2018
@spoenemann spoenemann mentioned this issue Mar 5, 2020
Closed
@akosyakov akosyakov self-assigned this Apr 30, 2020
@akosyakov akosyakov added shell issues related to the core shell and removed editor issues related to the editor labels Apr 30, 2020
@akosyakov akosyakov changed the title [editor] Editor not focused when one is closed [shell] transfer focus to next widget if the focused widget is closed Apr 30, 2020
@akosyakov akosyakov mentioned this issue Apr 30, 2020
Open
akosyakov added a commit to akosyakov/theia that referenced this issue May 1, 2020
@akosyakov
fix eclipse-theia#2234: activate another widget if an active widget g…
3f0452e 
…ets closed

support next/previous tab group commands
support next/previous tab in group commands

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue May 1, 2020
Merged
1 task
akosyakov added a commit to akosyakov/theia that referenced this issue May 1, 2020
@akosyakov
fix eclipse-theia#2234: activate another widget if an active widget g…
c78d1ec 
…ets closed

support next/previous tab group commands
support next/previous tab in group commands

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue May 4, 2020
@akosyakov
fix eclipse-theia#2234: activate another widget if an active widget g…
bb7462d 
…ets closed

support next/previous tab group commands
support next/previous tab in group commands

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue May 6, 2020
@akosyakov
fix #2234: activate another widget if an active widget gets closed
3d17ad2 
support next/previous tab group commands
support next/previous tab in group commands

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
enhancement issues that are enhancements to current functionality - nice to haves shell issues related to the core shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve widget focus handling akosyakov/theia
4 participants
@MarkZ3 @svenefftinge @dhuebner @akosyakov