Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

navigation between editors via Monaco does not work on master #4058

Closed
akosyakov opened this issue Jan 14, 2019 · 1 comment · Fixed by #4071
Closed

navigation between editors via Monaco does not work on master #4058

akosyakov opened this issue Jan 14, 2019 · 1 comment · Fixed by #4071
Assignees
@akosyakov
Labels
bug bugs found in the application monaco issues related to monaco

Comments

@akosyakov
Copy link
Member

not sure, how we missed it before, since last Monaco migration navigation between editors via Monaco does not work
@akosyakov akosyakov added bug bugs found in the application monaco issues related to monaco labels Jan 14, 2019
@akosyakov akosyakov self-assigned this Jan 14, 2019
@akosyakov akosyakov mentioned this issue Jan 14, 2019
Closed
akosyakov added a commit that referenced this issue Jan 15, 2019
@akosyakov
[monaco] fix #4058: fixed cross editor navigation
ff6b355 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Jan 15, 2019
Merged
akosyakov added a commit that referenced this issue Jan 15, 2019
@akosyakov
[monaco] fix #4058: fixed cross editor navigation
f25ca1e 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov
Copy link
Member Author

We did not notice it before, because it worked in the case if Monaco static services are instantiated via opening the editor. In the cases when they are instantiated without an editor, like accessing some language functions, default code editor service were installed. With #4058 our Monaco code editor service always overrides one which is installed statically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application monaco issues related to monaco
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[monaco] fixed cross editor navigation eclipse-theia/theia
1 participant
@akosyakov