Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

navigation from the editor preview widget does not work #4061

Closed
akosyakov opened this issue Jan 14, 2019 · 2 comments · Fixed by #9518
Closed

navigation from the editor preview widget does not work #4061

akosyakov opened this issue Jan 14, 2019 · 2 comments · Fixed by #9518
Assignees
@akosyakov
Labels
bug bugs found in the application editor issues related to the editor editor-preview issues that are related to the editor-preview

Comments

@akosyakov
Copy link
Member

For example from reference peek widget.

errors from console:

winjs.base.js:2057 Uncaught Error: Reference widget is not in the layout.
    at DockLayout.../../node_modules/@phosphor/widgets/lib/docklayout.js.DockLayout.addWidget (docklayout.js:323)
    at TheiaDockPanel.../../node_modules/@phosphor/widgets/lib/dockpanel.js.DockPanel.addWidget (dockpanel.js:303)
    at TheiaDockPanel.../../packages/core/lib/browser/shell/theia-dock-panel.js.TheiaDockPanel.addWidget (theia-dock-panel.ts:73)
    at ApplicationShell.../../packages/core/lib/browser/shell/application-shell.js.ApplicationShell.addWidget (application-shell.ts:668)
    at EditorManager.<anonymous> (widget-open-handler.ts:91)
    at step (widget-open-handler.ts:15)
    at Object.next (widget-open-handler.ts:15)
    at widget-open-handler.ts:15
    at new Promise (<anonymous>)
    at ../../packages/core/lib/browser/widget-open-handler.js.__awaiter (widget-open-handler.ts:15)
@akosyakov akosyakov added bug bugs found in the application editor issues related to the editor editor-preview issues that are related to the editor-preview labels Jan 14, 2019
@akosyakov
Copy link
Member Author

Needs fix for #4058 to reproduce

@AlexTugarev
Copy link
Contributor

Just opened references in a preview editor and navigation works nicely.

@akosyakov, is this still an issue?

@akosyakov akosyakov self-assigned this Aug 15, 2019
@colin-grant-work colin-grant-work mentioned this issue May 25, 2021
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application editor issues related to the editor editor-preview issues that are related to the editor-preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite editor-preview package as extensions of editor classes colin-grant-work/theia
2 participants
@AlexTugarev @akosyakov