Preserve system annotations and labels during object update #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haishi2016
reviewed
Nov 22, 2024
linyguo
force-pushed
the
users/lingyun/annotation
branch
from
366ab5f to
9e7725f
Compare
linyguo
changed the title
RemindD
reviewed
Dec 8, 2024
api/pkg/apis/v1alpha1/managers/activations/activations-manager.go
Outdated
Show resolved
Hide resolved
linyguo
force-pushed
the
users/lingyun/annotation
branch
from
fbba5cb to
193d02d
Compare
msftcoderdjw
previously approved these changes
Dec 10, 2024
RemindD
reviewed
Dec 10, 2024
Haishi2016
reviewed
Dec 10, 2024
linyguo
force-pushed
the
users/lingyun/annotation
branch
from
4b36300 to
eae2263
Compare
provider change detection change; Helm provider tag change (eclipse-symphony#575) * provider change detection change; Helm provider tag change * fix change state bug * add version for helm * remove no use code --------- Co-authored-by: Haishi Bai <hbai@microsoft.com> Co-authored-by: Jiawei Du <59427055+msftcoderdjw@users.noreply.github.com> catalog sample fix with portal adjustment to new schema (eclipse-symphony#581) fix retail scenario docs (eclipse-symphony#582) fix eclipse-symphony#550 by allow the job to be requeued (eclipse-symphony#578) Co-authored-by: Jiawei Du <59427055+msftcoderdjw@users.noreply.github.com> update etag and test fix ut fix ut
linyguo
force-pushed
the
users/lingyun/annotation
branch
from
8dbcbcb to
6ce5ae7
Compare
msftcoderdjw
requested changes
Dec 13, 2024
RemindD
approved these changes
Dec 13, 2024
msftcoderdjw
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #561
Fix #564 together