Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreachable code in create stage provider #564

Closed
Haishi2016 opened this issue Nov 20, 2024 · 1 comment · Fixed by #568
Closed

Unreachable code in create stage provider #564

Haishi2016 opened this issue Nov 20, 2024 · 1 comment · Fixed by #568
Labels
enhancement New feature or request P1

Comments

@Haishi2016
Copy link
Contributor

https://github.com/eclipse-symphony/symphony/blob/ccf7804b126ae531a3c6e5afb686743b0b2e004d/api/pkg/apis/v1alpha1/providers/stage/create/create.go#L327C3-L327C4
@msftcoderdjw
Copy link
Contributor

@linyguo is aware of this issue, and she is working on a fix in this PR: #568, together with other changes.

@linyguo linyguo mentioned this issue Nov 28, 2024
Merged
@msftcoderdjw msftcoderdjw added enhancement New feature or request P1 labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve system annotations and labels during object update linyguo/symphony
2 participants
@Haishi2016 @msftcoderdjw