Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Schedule to RFC 3339 format string #276

Merged
merged 9 commits into from
May 27, 2024

Conversation

FireDefend
Copy link
Contributor

No description provided.

Copy link
Contributor

@RemindD RemindD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We assign StageSpec.Schedule to ActivationData.Schedule so you need to change that part as well.

Overall, I would recommend changing ActivationData.Schedule to string type as well. And you need to check job-manager.go pollSchedules function where we check whether a scheduled stage need to triggered.
And we don't have integration tests to cover scheduled campaign currently, so I think it's a good chance to add a scheduled stage in 04.workflow test.

@msftcoderdjw
Copy link
Contributor

@FireDefend you need to register in eclipse foundation and sign off the eclipsefdn/eca before contribution. - https://www.eclipse.org/

test/localenv/mage Outdated Show resolved Hide resolved
@FireDefend
Copy link
Contributor Author

We assign StageSpec.Schedule to ActivationData.Schedule so you need to change that part as well.

Overall, I would recommend changing ActivationData.Schedule to string type as well. And you need to check job-manager.go pollSchedules function where we check whether a scheduled stage need to triggered. And we don't have integration tests to cover scheduled campaign currently, so I think it's a good chance to add a scheduled stage in 04.workflow test.

Tanks for reminding, added test

Copy link
Contributor

@msftcoderdjw msftcoderdjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest correcting all samples in docs about the schedule.

@FireDefend
Copy link
Contributor Author

Suggest correcting all samples in docs about the schedule.

fixed

@msftcoderdjw msftcoderdjw merged commit 6156e30 into eclipse-symphony:main May 27, 2024
5 checks passed
@FireDefend FireDefend deleted the xigsun/fix branch May 28, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants