-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Schedule to RFC 3339 format string #276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We assign StageSpec.Schedule to ActivationData.Schedule so you need to change that part as well.
Overall, I would recommend changing ActivationData.Schedule to string type as well. And you need to check job-manager.go pollSchedules function where we check whether a scheduled stage need to triggered.
And we don't have integration tests to cover scheduled campaign currently, so I think it's a good chance to add a scheduled stage in 04.workflow test.
@FireDefend you need to register in eclipse foundation and sign off the eclipsefdn/eca before contribution. - https://www.eclipse.org/ |
Tanks for reminding, added test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest correcting all samples in docs about the schedule.
fixed |
No description provided.