Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ScheduleSpec to Datetime #259

Closed
FireDefend opened this issue May 14, 2024 · 3 comments
Closed

Change ScheduleSpec to Datetime #259

FireDefend opened this issue May 14, 2024 · 3 comments
Assignees
Labels
bug Something isn't working P0

Comments

@FireDefend
Copy link
Contributor

Hi team, do you think it is possible to use datetime type instead of ScheduleSpec? Arm team is suggesting us to change it.

type ScheduleSpec struct {
Date string json:"date"
Time string json:"time"
Zone string json:"zone"
}

type StageSpec struct {
...
Schedule *ScheduleSpec json:"schedule,omitempty"
}


type StageSpec struct {
...
Schedule time.Time json:"datetime"
}

@Haishi2016
Copy link
Contributor

Think of usability scenarios: Schedule a deployment at 5PM on Friday (local time).

@Haishi2016 Haishi2016 added bug Something isn't working P0 labels May 16, 2024
@FireDefend
Copy link
Contributor Author

OpenAPI spec is using ISO 8601. It will support offset date time(local time). I think we can use the same standard to parse in symphony code. https://www.iso.org/iso-8601-date-and-time-format.html

@FireDefend
Copy link
Contributor Author

fixed by the PR: #276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0
Projects
None yet
Development

No branches or pull requests

2 participants