opera target view #246
Closed
opera target view #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Haishi2016 , eclipsefdn/eca checke failed in this PR. Can you please take a look? |
msftcoderdjw
requested changes
May 11, 2024
README.md
Outdated
| @@ -5,6 +5,10 @@ | |||
|
|
|||
| _(last edit: 02/02/2024)_ | |||
|
|
|||
| ### ⚠️⚠️⚠️ This branch hosts experimental features. The Symphony community does not guarantee long-term support for these features. Their incorporation into the main branch is not assured, and they may be deprecated or removed at any time without notice. For more details, please see [Experimental Feature Table](./experimental-features.md)⚠️⚠️⚠️ | |||
There was a problem hiding this comment.
Not include this in main.
| @@ -232,6 +239,7 @@ func (s *StageManager) ResumeStage(status model.ActivationStatus, cam model.Camp | |||
| TriggeringStage: stage, | |||
| Schedule: cam.Stages[nextStage].Schedule, | |||
| Namespace: namespace, | |||
| Proxy: cam.Stages[nextStage].Proxy, | |||
There was a problem hiding this comment.
These are the proxy processor changes, please remove them.
This is because there's a commit from action@github.com .... |
| @@ -50,6 +50,13 @@ func (t *TaskResult) GetError() error { | |||
| switch sv := v.(type) { | |||
| case v1alpha2.State: | |||
| break | |||
| case float64: | |||
There was a problem hiding this comment.
Just curious in which case, when will we get float64 status?
| annotations: Record<string, string>; | ||
| } | ||
|
|
||
| export interface TargetState { |
There was a problem hiding this comment.
I saw in this file, there's still some object like SolutionState which doesn't align new object model. Do we need to fix them?
* Merge ADO changes to OSS * refine k8s magefile * fix gatekeeper tests * export symphony logs in integration test * fix requeue when deployment is in-progress * Remove unnecessary isDeploymentFinished, use summaryResult.State to check * Remove unnecessary isDeploymentFinished, use summaryResult.State to check * Merge ADO changes to OSS * Remove unnecessary isDeploymentFinished, use summaryResult.State to check * pass context in apiclient call * addressing comments * adjust log level * fix typo and use time.Now().UTC() in metrics
* remove Docker check; remove 'v' prefix of version parameter * remove v prefix for powershell
* Merge ADO K8S changes to OSS * honor OSS changes * expose delete sync delay for futuer override from helm charts * generate helm charts * fix typo in InstanceStatus * add debug logs for k8s target provider * refactor webhook and add metrics * refactor reconciliation policy to meet API spec * watch operationId change instead of annnotation change * webhook fixes * fix typo * refine reconciliation policy * refactor doc * remove version property in target/intance since we will have new version implementation * fix typo
* Support device in non-default namespace * fix missing argument in test * handle missing namespace field * Fix provisiongingStatus missing error in target update
* remove catalog.spec.name * remove instance.spec.name * remove spec.name in catalog/instance k8s object * fix catalog webhook * remove spec.name in catalog in docs and tests * remove spec.name in activation * remove spec.name in campaign * fix samples in symphony object in catalog for materializing --------- Co-authored-by: Jiawei Du <jiadu@microsoft.com> Co-authored-by: Haishi2016 <hbai@microsoft.com>
* coa first round (#3) * coa first round * enable manual trigger * fix otel dependency issue * fix api and k8s tests * add header --------- Co-authored-by: Jiawei Du <jiaweidu_js@163.com> * API done * tidy api/go.mod * fixes * enable more cases * refine ensureNamespace * refine tests * tidy k8s/go.mod * refine cases * verify * fix mage remove * refine go.mod in api & k8s * refine go.work and go.mod in tests * fix naming * temp * enable ginkogo test * fix deploymenthash and tested ginkgo tests * fix github.com/stretchr/objx * fix startup * testing * fix requeue due to update change * resolve a rebase issue * [Temp] Enable tests * Refine mage commands for tests * fix tests and github action * remove adomerge_staging branch * increase go test timeout to 1min * increase go test timeout to 5min * fix constant value * fix unnecessary changes * refine gatekeeper tests * Merge ADO changes to OSS * refine k8s magefile * fix gatekeeper tests * export symphony logs in integration test * fix requeue when deployment is in-progress * Remove unnecessary isDeploymentFinished, use summaryResult.State to check * Remove unnecessary isDeploymentFinished, use summaryResult.State to check * fix merge issues * first draft * checkpoint SAT * second version * Merge ADO K8S changes to OSS * honor OSS changes * expose delete sync delay for futuer override from helm charts * generate helm charts * fix typo in InstanceStatus * add debug logs for k8s target provider * refactor webhook and add metrics * refactor reconciliation policy to meet API spec * watch operationId change instead of annnotation change * webhook fixes * fix typo * refine reconciliation policy * refactor doc * remove version property in target/intance since we will have new version implementation * fix typo * fix dependency issues * clean up work * add ado suite test pipeline * resolve comments * resolve comments * resolve comments * resolve comments * fix helmTemplate * change timeout to 90 in local env mage file * upate cert manager chart version --------- Co-authored-by: Jiawei Du <jiaweidu_js@163.com> Co-authored-by: Jiawei Du <jiadu@microsoft.com>
…in release pipeline (#247) * Fix checkout/commit/push users * address comments
Signed-off-by: Thomas Neidhart <thomas.neidhart@eclipse-foundation.org>
* enable proxy stage processor * initial stage isolation docs * udpate k8s types * workflow docs and samples continued * fix update target result (#227) * fix http test --------- Co-authored-by: Jiawei Du <59427055+msftcoderdjw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be safe to merge as it affects only the opera portal.