Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BOT_USER (eclipse-symphoy-bot) to checkout, commit, push changes in release pipeline #247

Merged
merged 2 commits into from
May 7, 2024

Conversation

msftcoderdjw
Copy link
Contributor

Context:

eclipse-symphony/.eclipsefdn#4

Suggestions by eclipse forks:

so I see that you request these changes in order to support your release workflow that fails now.

This is a common problem with github actions and can not be easily solved by a bypass rule for github actions, as there is no user like that.

However, what we have done for other projects and is also good practice is the following:

  • inject a token as secret that allows to bypass the branch protection rule

  • add the eclipse-symphoy-bot user to the bypass list (as already done in this PR)

  • disable status checks as this is not compatible with direct pushes

  • adapt your release workflow like that:

so if I look at your existing release workflow, only a few things have to change:

  • use then the injected token instead of secrets.GITHUB_TOKEN

  • update our git config to use

Changes:

  1. Use BOT_USER_NAME (eclipse-symphony-bot) to checkout, commit and push changes in release pipeline.
  2. https://github.com/eclipse-symphony/.eclipsefdn/pull/4/files (eclipse-symphony-bot is added in bypass_pull_request_allowances list.)

@msftcoderdjw msftcoderdjw merged commit 4262293 into eclipse-symphony:main May 7, 2024
4 checks passed
Haishi2016 pushed a commit that referenced this pull request May 15, 2024
…in release pipeline (#247)

* Fix checkout/commit/push users

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants