Mention the preferred version of GCC on Windows #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know in the past the IBM SDK used a different version on mingw (gcc) than the one listed here. Do you know if the version listed here generates code that performs as well as the older versions of mingw? |
|
@charliegracie see #727 for the performance results |
|
This is ready for review & merge. |
pshipton
reviewed
Feb 28, 2018
buildenv/Build_Instructions_V9.md
Outdated
| @@ -311,7 +311,7 @@ The following instructions guide you through the process of building a Windows O | |||
| :ledger: | |||
| You must install a number of software dependencies to create a suitable build environment on your system: | |||
|
|
|||
| - [Cygwin](https://cygwin.com/install.html), which provides a Unix-style command line interface. Install all packages in the `Devel` category. In the `Archive` category, install the packages `zip` and `unzip`. Install any further package dependencies that are identified by the installer. More information about using Cygwin can be found [here](https://cygwin.com/docs.html). | |||
| - [Cygwin](https://cygwin.com/install.html), which provides a Unix-style command line interface. Install all packages in the `Devel` category. In the `Archive` category, install the packages `zip` and `unzip`. Install any further package dependencies that are identified by the installer. More information about using Cygwin can be found [here](https://cygwin.com/docs.html). OpenJ9 is tested with version 6.4.0 of GCC, provided by default with current Cygwin installations. Other versions are expected to work also. | |||
There was a problem hiding this comment.
Should this say mingw instead of GCC?
Signed-off-by: Peter Bain <peter_bain@ca.ibm.com>
|
Thanks for the comment. |
pshipton
approved these changes
Feb 28, 2018
|
@SueChaplain fyi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #727 and #922
Signed-off-by: Peter Bain peter_bain@ca.ibm.com