Add build instructions for OpenJDK8 Windows 64-bit #857
Conversation
SueChaplain
force-pushed
the
jdk8onwin64
branch
from
b3205ab to
24f3006
Compare
|
please make the same update as #924, once this change is merged |
|
Please fix the copyright |
SueChaplain
force-pushed
the
jdk8onwin64
branch
from
24f3006 to
5e7d531
Compare
|
Copyright fixed |
Add section to existing detailed build instructions to cover building a Windows 64-bit binary. See issue eclipse-openj9#845. Modified commit to fix image directory names, which are different from version 9. See issue eclipse-openj9/openj9-website#56 raised for the website. Applies here too. Modified commit to update copyright and add the Windows debugging tools and VS service pack additions identified by Violetta. [ci skip] Issue eclipse-openj9#845 Signed-off-by: Sue Chaplain <sue_chaplain@uk.ibm.com>
SueChaplain
force-pushed
the
jdk8onwin64
branch
from
5e7d531 to
7ecf260
Compare
buildenv/Build_Instructions_V8.md
Outdated
| ``` | ||
| set INCLUDE ="C:\Program Files\Debugging Tools for Windows (x64)\sdk\inc";%INCLUDE% | ||
| set LIB="C:\Program Files\Debugging Tools for Windows (x64)\sdk\lib";%LIB%; | ||
| ``` |
There was a problem hiding this comment.
When I tried to follow these instructions having quotes here, either around just the path being prepended or around the whole thing made OpenJDK's configure fail. Getting rid of the quotes made it happy.
| cd c:\temp | ||
| msbuild.exe C:/temp/freetype/builds/windows/vc2010/freetype.vcxproj /p:PlatformToolset=v100 /p:Configuration="Release Multithreaded" /p:Platform=x64 /p:ConfigurationType=DynamicLibrary /p:TargetName=freetype /p:OutDir="C:/temp/freetype/lib64/" /p:IntDir="C:/temp/freetype/obj64/" > freetype.log | ||
| msbuild.exe C:/temp/freetype/builds/windows/vc2010/freetype.vcxproj /p:PlatformToolset=v100 /p:Configuration="Release Multithreaded" /p:Platform=x64 /p:ConfigurationType=StaticLibrary /p:TargetName=freetype /p:OutDir="C:/temp/freetype/lib64/" /p:IntDir="C:/temp/freetype/obj64/" >> freetype.log | ||
| ``` |
There was a problem hiding this comment.
I noticed that this is how OpenJDK9 builds freetype as well, but it doesn't really do what was intended. This is building both a dynamic library and a static library, and later linking against the static library; the DLL is completely unused. The intention seems to be to build a DLL and the corresponding import library, not a static library. The MSVC linker produces import libraries for DLLs automatically when DLLs export things, but this version of freetype doesn't export any symbols. Looks like it's fixed in later versions and the public API is declared with __declspec(dllexport), but for this one either the source would need to be modified or an exports file declaring some symbols would need to be fed to the linker.
There was a problem hiding this comment.
Hi @ymanton. The build process has moved from using VisualStudio to mingw, which would change this part, but I've yet to get input on how mingw builds the Freetype stuff. There's more discussion in the pull request.
There was a problem hiding this comment.
The build process did not move from using VisualStudio to mingw. The build still uses VisualStudio but mingw must be present because its used to compile ~3 files.
There was a problem hiding this comment.
@ymanton do the instructions work, even if not perfect, or are changes to the instructions required to make it work?
There was a problem hiding this comment.
Aside from the quotes issue mentioned above that should be changed, yes they work.
There's a bug in the OMR build files that bit me, but it depends on what your PATH is set to and I submitted a PR to them to fix that.
|
I see the travis-ci now. Note the travis-ci tests compiling OpenJ9 and isn't affected by this change. In the future, |
Add section to existing detailed build instructions
to cover building a Windows 64-bit binary. See
issue #845.
[ci skip]
Closes #845
Signed-off-by: Sue Chaplain sue_chaplain@uk.ibm.com