Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer pass Artifactory details to Test Pipelines #5179

Merged

Conversation

AdamBrousseau
Copy link
Contributor

  • Test jobs will have default params set

Related #5146 #2637 #4705
[skip ci]

Signed-off-by: Adam Brousseau adam.brousseau88@gmail.com

- Test jobs will have default params set

Related eclipse-openj9#5146 eclipse-openj9#2637 eclipse-openj9#4705
[skip ci]

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
@AdamBrousseau
Copy link
Contributor Author

@jdekonin and @llxia for review. Note this will need to merge after at least the internal Test jobs are regenerated.

@llxia
Copy link
Contributor

llxia commented Mar 20, 2019

We have set ARTIFACTORY_SERVER in internal test jobs already. Did we miss any test job?

@AdamBrousseau
Copy link
Contributor Author

True. So this can be merged now since the test code has default repo value as sys-rt-generic-local. And once the external jobs are regenerated with server and repo then Artifactory will be enabled for test jobs there.

Copy link
Contributor

@jdekonin jdekonin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants