-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Artifactory details for Eclipse OpenJ9 Jenkins #4705
Merged
pshipton
merged 1 commit into
eclipse-openj9:master
from
AdamBrousseau:add_artifactory_details
Mar 21, 2019
Merged
Add Artifactory details for Eclipse OpenJ9 Jenkins #4705
pshipton
merged 1 commit into
eclipse-openj9:master
from
AdamBrousseau:add_artifactory_details
Mar 21, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c182f88
to
cf5ed08
Compare
This was referenced Feb 14, 2019
c6565d4
to
1941bff
Compare
c75afc4
to
414867f
Compare
334a884
to
61db9fd
Compare
c97fe43
to
1e57d55
Compare
@jdekonin for review |
- This will enable builds to push to Artifactory Issue eclipse-openj9#2637 Related eclipse-openj9#5146 [skip ci] Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
1e57d55
to
ddcacc1
Compare
AdamBrousseau
added a commit
to AdamBrousseau/openj9
that referenced
this pull request
Mar 19, 2019
- Test Pipelines require this or they default to sys-rt-generic-local which is undesirable. - Add Jenkins Domain to Artifactory path - Test Pipelines already have the domain as part of the path. This will match that behaviour. - See openjdk-tests/JenkinsfileBase#L478 Issue eclipse-openj9#2637 Related eclipse-openj9#4705 [skip ci] Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
AdamBrousseau
added a commit
to AdamBrousseau/openj9
that referenced
this pull request
Mar 20, 2019
- Test jobs will have default params set Related eclipse-openj9#5146 eclipse-openj9#2637 eclipse-openj9#4705 [skip ci] Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
This was referenced Mar 20, 2019
jdekonin
approved these changes
Mar 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. @pshipton for review/merge.
pshipton
approved these changes
Mar 21, 2019
AdamBrousseau
added a commit
to AdamBrousseau/openj9
that referenced
this pull request
Mar 22, 2019
Related eclipse-openj9#4705 [skip ci] Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2637
Related #5146
[skip ci]
Signed-off-by: Adam Brousseau adam.brousseau88@gmail.com