Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Artifactory details for Eclipse OpenJ9 Jenkins #4705

Merged

Conversation

AdamBrousseau
Copy link
Contributor

@AdamBrousseau AdamBrousseau commented Feb 12, 2019

  • This will enable builds to push to Artifactory

Issue #2637
Related #5146
[skip ci]

Signed-off-by: Adam Brousseau adam.brousseau88@gmail.com

@AdamBrousseau AdamBrousseau force-pushed the add_artifactory_details branch from c182f88 to cf5ed08 Compare February 12, 2019 18:40
@AdamBrousseau AdamBrousseau force-pushed the add_artifactory_details branch 4 times, most recently from c6565d4 to 1941bff Compare February 22, 2019 15:35
@AdamBrousseau AdamBrousseau force-pushed the add_artifactory_details branch 2 times, most recently from c75afc4 to 414867f Compare March 5, 2019 16:19
@AdamBrousseau AdamBrousseau force-pushed the add_artifactory_details branch 5 times, most recently from 334a884 to 61db9fd Compare March 13, 2019 14:22
@AdamBrousseau AdamBrousseau force-pushed the add_artifactory_details branch 2 times, most recently from c97fe43 to 1e57d55 Compare March 19, 2019 19:34
@AdamBrousseau AdamBrousseau changed the title WIP: Add artifactory details Add Artifactory details for Eclipse OpenJ9 Jenkins Mar 19, 2019
@AdamBrousseau
Copy link
Contributor Author

@jdekonin for review

- This will enable builds to push to Artifactory

Issue eclipse-openj9#2637
Related eclipse-openj9#5146
[skip ci]

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
@AdamBrousseau AdamBrousseau force-pushed the add_artifactory_details branch from 1e57d55 to ddcacc1 Compare March 19, 2019 19:36
AdamBrousseau added a commit to AdamBrousseau/openj9 that referenced this pull request Mar 19, 2019
- Test Pipelines require this or they default to
  sys-rt-generic-local which is undesirable.
- Add Jenkins Domain to Artifactory path
- Test Pipelines already have the domain as
  part of the path. This will match that behaviour.
- See openjdk-tests/JenkinsfileBase#L478

Issue eclipse-openj9#2637
Related eclipse-openj9#4705
[skip ci]

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
AdamBrousseau added a commit to AdamBrousseau/openj9 that referenced this pull request Mar 20, 2019
- Test jobs will have default params set

Related eclipse-openj9#5146 eclipse-openj9#2637 eclipse-openj9#4705
[skip ci]

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
Copy link
Contributor

@jdekonin jdekonin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @pshipton for review/merge.

@pshipton pshipton merged commit b241e7f into eclipse-openj9:master Mar 21, 2019
AdamBrousseau added a commit to AdamBrousseau/openj9 that referenced this pull request Mar 22, 2019
Related eclipse-openj9#4705
[skip ci]

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants