Clean up of Concurrent Scavenge code on Power #4712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment regarding compatibility of TM and concurrent scavenge was updated. At the current time there are no plans to be able to support both at the time time so it was removed as being a TODO. stopUsingRegister already performs a NULL check on the register so the NULL checks before the calls were unnecessary. Issue: eclipse-openj9#3421 Signed-off-by: jimmyk <jimmyk@ca.ibm.com>
|
Travis CI builds looked like they failed because: Edit: I am being told this is a known issue right now. |
fjeremic
approved these changes
Feb 12, 2019
|
Oops, I think we have not merged it. Will merge now. |
|
@pshipton can we get this into 0.13? |
|
@gita-omr yes, there was nothing else blocking it, so I've pushed this to the 0.13 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment regarding compatibility of TM and concurrent scavenge was updated.
At the current time there are no plans to be able to support both at the
time time so it was removed as being a TODO.
stopUsingRegister already performs a NULL check on the register so the
NULL checks before the calls were unnecessary.
Issue: #3421
Signed-off-by: jimmyk jimmyk@ca.ibm.com