Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AArch64: Update build instructions #4696

Merged
merged 1 commit into from
Mar 20, 2019
Merged

AArch64: Update build instructions #4696

merged 1 commit into from
Mar 20, 2019

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Feb 12, 2019

This commit adds description in the AArch64 section.

Signed-off-by: knn-k konno@jp.ibm.com

@knn-k
Copy link
Contributor Author

knn-k commented Feb 12, 2019

I need the following PRs to be merged for AArch64 VM to be buildable:

@SueChaplain
Copy link
Contributor

@knn-k

A suggestion for your last sentence to help clarify use for the -Xint option:

You will see a warning for libj9jit29.so if you don't use the -Xint option.

How about "If you don't disable the JIT compiler with the -Xint option, you will see a warning for libj9jit29.so.

@knn-k
Copy link
Contributor Author

knn-k commented Feb 12, 2019

@SueChaplain Thank you for your comment. I am going to change it following your suggestion.

@knn-k knn-k force-pushed the aarch64build6 branch 3 times, most recently from b9634d0 to 130c77d Compare February 18, 2019 08:31
@knn-k
Copy link
Contributor Author

knn-k commented Feb 18, 2019

Removed --with-noncompressedrefs from the configure options, and added a comment for Non-compressed references support: instead, as #4749 has been merged.

@knn-k
AArch64: Update build instructions
5bd909e 
This commit adds description in the AArch64 section.

Signed-off-by: knn-k <konno@jp.ibm.com>
@knn-k
Copy link
Contributor Author

knn-k commented Feb 25, 2019

Building the runtime with OpenSSL support --with-openssl=fetched fails because the build process compiles the OpenSSL library not for aarch64 but x86-64.

@knn-k knn-k changed the title WIP: AArch64: Update build instructions AArch64: Update build instructions Feb 27, 2019
@0xdaryl
Copy link
Contributor

0xdaryl commented Feb 28, 2019

@SueChaplain , are you fine with these changes?

@SueChaplain
Copy link
Contributor

@0xdaryl - LGTM. Thanks!

@knn-k
Copy link
Contributor Author

knn-k commented Mar 7, 2019

I opened #5018 for the issue in building with OpenSSL I mentioned before.

@pshipton pshipton mentioned this pull request Mar 7, 2019
Closed
This was referenced Mar 8, 2019
Closed
Open
@knn-k
Copy link
Contributor Author

knn-k commented Mar 20, 2019

Is there anything blocking this PR from getting merged?

@0xdaryl 0xdaryl self-assigned this Mar 20, 2019
@0xdaryl 0xdaryl merged commit 927d075 into eclipse-openj9:master Mar 20, 2019
@knn-k knn-k deleted the aarch64build6 branch March 20, 2019 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xdaryl 0xdaryl 0xdaryl approved these changes

Assignees

@0xdaryl 0xdaryl

Labels
comp:doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knn-k @SueChaplain @0xdaryl