-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AArch64: Implement unsafe helper functions #3502
Conversation
The Travis CI build failed with:
This is not caused by this commit. |
I guess you also need to add vpath to module.xml for AArch64: |
There are also changes required in https://github.com/eclipse/openj9/blob/master/runtime/vm/gphandle.c#L238 that handles SIGBUS from the unsafe helpers. The idea is that when SIGBUS is triggered from accessing the invalid address in the unsafe helpers, we know the UNSAFE_TARGET_REGISTER (x0 here) has the invalid address, then we update this register to an writable/readable but garbage address on stack, so that we can bypass the offending instruction and turn SIGBUS into an exception. If you are not making the above change in this PR, please put some comments in unsafeHelper.s and gphandle.c saying that this needs to be done on AArch64. |
@hangshao0 Thanks for your comments. I will add vpath to module.xml. What should the spec name be for AArch64? I would say |
Updated files reflecting the comments. |
I am fine with this name.
Yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm assuming the linux_aarch64
spec is being added in a separate PR
Jenkins compile xlinux jdk8 |
@knn-k can you rebase to resolve the conflict? I think it should be fairly straightforward |
ea714b7
to
a6c1ffd
Compare
Resolved merge conflict. |
Sorry @knn-k hopefully the last minor change - the end date in the copyrights of changed files must be
|
This commit implements the unsafe helper functions for aarch64. Signed-off-by: knn-k <konno@jp.ibm.com>
Corrected copyright years. |
Jenkins compile xlinux jdk8 |
I would like this to be merged if the code is OK. |
This commit implements the unsafe helper functions for aarch64.
Signed-off-by: knn-k konno@jp.ibm.com