Fix for missing NULLCHK under Concurrent Scavenge #3798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NULLCHK may be missing under concurrent scavenge on non-compressedrefs build; fixing. Signed-off-by: Victor Ding <dvictor@ca.ibm.com>
|
@0dvictor Why isn't the NULLCHK case being handled with a simple check of if the treetop is NULLCHK then we need to create a NULLCHK of the grandchild (whatever it is) then anchor the child? I guess why are we only looking for two patterns? |
|
We only should create NULLCHK when anchoring |
|
Jenkins test sanity xlinux,win,plinux jdk8,jdk11 |
|
win jdk11 failed due to infra. Everything else is clean and the test did pass on JDK8 win so I'm happy to merge since this should not be jdk specific - just GC mode sensitive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NULLCHK may be missing under concurrent scavenge on non-compressedrefs
build; fixing.
Signed-off-by: Victor Ding dvictor@ca.ibm.com