Add new DDR commands for modularity__Command 1 and 2 #1987

Ailloviee · 2018-05-24T20:08:46Z

Added two commands:

!findallmodules Outputs all the modules loaded by the runtime
findmodulebyname <moduleName> find the modules corresponding to its module name
Related issue: Add new DDR commands for modularity #1859

Refactored ObjectModel.java and CheckEngine.java to make some pointer check helper functions public static.

Made change in PointerGenerator.java as DDR wouldn't compile without the change, for detail look at: #1973

Signed-off-by: Charles_Zheng Juntian.Zheng@ibm.com

Examples:
findallmodules:

> !findallmodules
jdk.javadoc                    !j9module 0x000001305F474498
jdk.attach                     !j9module 0x000001305F478798
java.prefs                     !j9module 0x000001305F478928
java.sql.rowset                !j9module 0x000001305F4789C8
jdk.security.auth              !j9module 0x000001305F478BF8
jdk.editpad                    !j9module 0x000001305F478D88
jdk.crypto.cryptoki            !j9module 0x000001305F478E78
java.rmi                       !j9module 0x000001305F478F68
jdk.httpserver                 !j9module 0x000001305F479468
jdk.internal.jvmstat           !j9module 0x000001305F4795A8
java.datatransfer              !j9module 0x000001305F476668
jdk.scripting.nashorn          !j9module 0x000001305F4767A8
jdk.jdwp.agent                 !j9module 0x000001305F477248
openj9.cuda                    !j9module 0x000001305F477298
java.logging                   !j9module 0x000001305F477388
openj9.dataaccess              !j9module 0x000001305F477CC8
jdk.naming.rmi                 !j9module 0x000001305F477D68
jdk.crypto.ec                  !j9module 0x000001305F477E58
java.naming                    !j9module 0x000001305F477EF8
jdk.management                 !j9module 0x000001305F478448
jdk.jlink                      !j9module 0x000001305F4699A8
jdk.jconsole                   !j9module 0x000001305F469D18
jdk.accessibility              !j9module 0x000001305F469EA8
openj9.dtfj                    !j9module 0x000001305F469FE8
openj9.zosconditionhandling    !j9module 0x000001305F4710C8
jdk.localedata                 !j9module 0x000001305F471168
jdk.charsets                   !j9module 0x000001305F471398
java.smartcardio               !j9module 0x000001305F471438
openj9.jvm                     !j9module 0x000001305F471528
jdk.jstatd                     !j9module 0x000001305F4715C8
java.security.jgss             !j9module 0x000001305F471708
jdk.net                        !j9module 0x000001305F471CF8
jdk.jshell                     !j9module 0x000001305F471D98
java.management                !j9module 0x000001305F468B18
jdk.internal.ed                !j9module 0x000001305F4691A8
jdk.management.agent           !j9module 0x000001305F469298
jdk.crypto.mscapi              !j9module 0x000001305F469478
jdk.jdeps                      !j9module 0x000001305F469518
java.xml                       !j9module 0x000001305F46BCB8
jdk.internal.opt               !j9module 0x000001305F46ABA8
jdk.compiler                   !j9module 0x000001305F46ACE8
jdk.jartool                    !j9module 0x000001305F46B6E8
jdk.internal.le                !j9module 0x000001305F46B8C8
jdk.unsupported                !j9module 0x000001305F4684A8
jdk.dynalink                   !j9module 0x000001305F4685E8
java.scripting                 !j9module 0x000001305F46DD98
java.se                        !j9module 0x000001305F46DE88
java.security.sasl             !j9module 0x000001305F46DED8
java.management.rmi            !j9module 0x000001305F46E0B8
java.desktop                   !j9module 0x000001305F46E1F8
jdk.naming.dns                 !j9module 0x000001305F46CCD8
java.xml.crypto                !j9module 0x000001305F46CDC8
jdk.sctp                       !j9module 0x000001305F46D868
jdk.security.jgss              !j9module 0x000001305F46D958
jdk.jsobject                   !j9module 0x000001305F46DA48
java.instrument                !j9module 0x000001305F46DB38
java.sql                       !j9module 0x00000130550DB798
jdk.zipfs                      !j9module 0x00000130550DB8D8
openj9.gpu                     !j9module 0x00000130550DB978
openj9.sharedclasses           !j9module 0x00000130550DBA68
jdk.xml.dom                    !j9module 0x00000130550DBB58
java.compiler                  !j9module 0x00000130550DBCE8
jdk.jdi                        !j9module 0x00000130550DBF18
java.base                      !j9module 0x00000130550C7E88

findmodulebyname:

> !findmodulebyname java.base
Searching for modules named 'java.base' in VM=13053677e00
java.base			!j9module 0x00000130550C7E88
Found 1 module(s) named java.base

Also, added test cases for the two commands

tajila · 2018-05-24T20:09:36Z

debugtools/DDR_VM/src/com/ibm/j9ddr/tools/PointerGenerator.java

@@ -274,7 +274,7 @@ private void generateClass(StructureDescriptor structure) throws IOException {
 		File javaFile = new File(outputDir, structure.getPointerName() + ".java");

 		// Do not create Pointer class for Constant only structures (this includes enums)
-		if (structure.getFields().size() == 0 && structure.getConstants().size() != 0 && superClassName.equals("StructurePointer")) {
+		if (structure.getFields().size() == 0 && structure.getConstants().size() > 1 && superClassName.equals("StructurePointer")) {


take out these changes Keith has submitted a fix for this

tajila · 2018-05-24T20:10:07Z

...ols/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindModuleByNameCommand.java

+		}
+	}
+
+	 /**


fix indentation

tajila · 2018-05-24T20:11:20Z

@Ailloviee please post an example of what the two commands output in this PR

tajila · 2018-05-24T20:11:51Z

@dmitripivkine Please take a look at this PR, it refactors some of the checkEngine and ObjectModel code

tajila · 2018-05-24T21:49:00Z

...tools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindAllModulesCommand.java

+			J9ModulePointer modulePtr = null;
+			while (poolIterator.hasNext()) {
+				modulePtr = poolIterator.next();
+				if (ObjectModel.isPointerInHeap(vm, modulePtr.moduleName())) {


add a comment saying why this check must be done

tajila · 2018-05-24T21:50:33Z

...tools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindAllModulesCommand.java

+					out.printf("%s			!j9module %s\n", moduleName, hexAddress);
+				}
+			}
+		} catch (Exception/* CorruptDataException */ e) {


if CorruptDataException is the only exception that can be thrown in the try block then specify it in the catch block

tajila · 2018-05-25T14:55:43Z

@Ailloviee can you fix the ObjectModel diff, its too large

Ailloviee · 2018-05-25T15:29:06Z

Sorry I tried to squash the commits but I did it wrong and there was merge conflicts

dmitripivkine

GC DDR changes LGTM

tajila · 2018-05-30T18:11:43Z

debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/j9/ObjectModel.java

+		return null;
+	}
+
+	// TODO kmt : this doesn't belong here


remove this comment, no longer applies since you've moved it

also add javadocs

tajila · 2018-05-30T18:12:14Z

debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/j9/ObjectModel.java

+	 * 					any abstract pointer
+	 * @return If the AbstractPointer pointer is in stored in heap.
+	 */
+


remove this space

tajila · 2018-05-30T18:12:31Z

debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/j9/ObjectModel.java

@@ -362,4 +369,69 @@ public static VoidPointer getElementAddress(J9IndexableObjectPointer indexableOb
 	{
 		return gcObjectModel.getElementAddress(indexableObjectPointer, elementIndex, elementSize);
 	}
+
+	public static GCHeapRegionDescriptor findRegionForPointer(J9JavaVMPointer javaVM, GCHeapRegionManager hrm, AbstractPointer pointer, GCHeapRegionDescriptor region)


add javadocs for this

tajila · 2018-05-30T18:12:52Z

debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/j9/ObjectModel.java

+		} catch (CorruptDataException cde) {}
+		return null;
+	}
+


add javadocs

tajila · 2018-05-30T18:13:28Z

debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/j9/ObjectModel.java

+	 * <p>
+	 * @param 	javaVM
+	 * 					J9JavaVMPointer
+	 * 			pointer


formatting looks off here, add the @param for each parameter

tajila · 2018-05-30T18:14:17Z

...tools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindAllModulesCommand.java

+ * 			java.prefs			!j9module 0x000001305F478928
+ *			.....(A list of every module loaded by the runtime)
+ */
+


remove space

tajila · 2018-05-30T18:16:27Z

...tools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindAllModulesCommand.java

+				/*
+				 * Since both packages and modules could be in the pool,
+				 * the iterator checks on the region and make sure that it is
+				 * pointing to a module. (For modules, the pointer must be in heap)


try to be more specific and mention that we distinguish between module and j9package by checking if the first field is in the heap. Since the first field for j9module is an object and the first field for j9package is a J9UTF8

tajila · 2018-05-30T18:18:04Z

debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/j9/ObjectModel.java

+	public static GCHeapRegionDescriptor regionForAddress(J9JavaVMPointer javaVM, GCHeapRegionManager hrm, AbstractPointer pointer)
+	{
+		try {
+			if(null == hrm) {


should be a space after the if

if (null ...

tajila · 2018-05-30T18:18:25Z

debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/j9/ObjectModel.java

+
+	public static boolean isPointerInHeap(J9JavaVMPointer javaVM, AbstractPointer pointer)
+	{
+		if(findRegionForPointer(javaVM, null, pointer, null) != null) {


should be space after if

tajila · 2018-05-30T18:19:40Z

debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/j9/ObjectModel.java

+		if(findRegionForPointer(javaVM, null, pointer, null) != null) {
+			return true;
+		}
+		else {


tajila · 2018-05-30T21:07:10Z

debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/j9/ObjectModel.java

@@ -358,8 +365,104 @@ public static UDATA getHeaderSize(J9ObjectPointer object) throws CorruptDataExce
 		return gcObjectModel.getHeaderSize(object);
 	}

+	/**
+	 * Returns the address of an element.
+	 * <p>


dont need this

tajila · 2018-05-30T21:07:18Z

debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/j9/ObjectModel.java

+
+	/**
+	 * Returns the heap region of a pointer.
+	 * <p>


dont need this

tajila · 2018-05-30T21:07:25Z

debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/j9/ObjectModel.java

+
+	/**
+	 * Returns the heap region for address of a pointer.
+	 * <p>


same for the rest

tajila · 2018-05-30T21:08:00Z

@keithc-ca can you please review these changes

keithc-ca

Have the new commands been tested with a core file produced by Java 8?

keithc-ca · 2018-05-31T13:52:22Z

...tools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindAllModulesCommand.java

+				 * J9UTF8)
+				 */
+				if (ObjectModel.isPointerInHeap(vm, modulePtr.moduleName())) {
+					String moduleName = J9ObjectHelper.stringValue(modulePtr.moduleName());


Please pull the expression modulePtr.moduleName() out of the loop.

keithc-ca · 2018-05-31T13:52:49Z

...ols/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindModuleByNameCommand.java

+{
+	public FindModuleByNameCommand()
+	{
+		addCommand("findmodulebyname","<moduleName>","find the modules corresponding to its module name");


nit (formatting): space after comma

keithc-ca · 2018-05-31T13:53:56Z

...ols/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindModuleByNameCommand.java

+			while (poolIterator.hasNext()) {
+				modulePtr = poolIterator.next();
+				if (ObjectModel.isPointerInHeap(vm, modulePtr.moduleName())
+						&& pattern.isMatch(J9ObjectHelper.stringValue(modulePtr.moduleName()))) {


Please extract the expression modulePtr.moduleName() into a local variable.

Ailloviee · 2018-05-31T14:37:59Z

@keithc-ca So far I've only tested with core file generated by Java 10, can you please teach me how to generate core file using Java 8? -Xdump does not seem to work on Java 8

pshipton · 2018-05-31T14:50:02Z

-Xdump does not seem to work on Java 8

What are you trying? -Xdump works the same on Java 8 as it does on Java 10, although Java 8 doesn't support modules. I assume Keith is asking you to check the commands fail gracefully on a Java 8 core.
"java -Xdump:system:events=vmstop" is one way, create a core on shutdown.
"java -Xdump:system:events=user" is another if you have something long running, then send the QUIT signal "kill -QUIT " to create a core file.

tajila · 2018-05-31T15:13:44Z

@Ailloviee when you are testing with Java8 make sure its a J9 or Openj9 and not hotspot

keithc-ca · 2018-05-31T15:51:20Z

@pshipton is right: I want to know that you've tried the commands on a core file from Java 8, that it behaves 'gracefully', and what that graceful behavior is.

Ailloviee · 2018-05-31T16:04:17Z

@pshipton @keithc-ca for now it fails but not gracefully, working on the version handling now

AdamBrousseau · 2018-06-01T19:07:27Z

Jenkins signed off by check

Ailloviee · 2018-06-01T19:59:52Z

@keithc-ca @pshipton New commands now fail gracefully on Java 8, example:

> !findallmodules
This command only works with Java version 9 or higher
The current Java version is: Java 1.8

tajila · 2018-06-01T20:24:53Z

debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/JavaVersionHelper.java

+import com.ibm.j9ddr.vm29.types.UDATA;
+
+/**
+ * JavaVersionHelper helps check if the JVM version is new enough for the modularity DDR commands


remove the part about "modularity DDR commands". This class should be general enough for other purposes

keithc-ca · 2018-06-04T13:56:41Z

debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/JavaVersionHelper.java

+	public final static int J2SE_18 = 0x0800;
+	public final static int J2SE_19 = 0x0900;
+	public final static int J2SE_V10 = 0x0A00;
+	public final static int J2SE_V11 = 0x0B00;


I'd like to see this written so it doesn't need attention with every new version.
The comments in j2sever.h suggest vm.j2seVersion().bitAnd(J2SE_VERSION_MASK) will give the right answer until Java version 255. The J2SE_* constants for 8-11 are thus not necessary.

vm.j2seVersion().bitAnd(J2SE_VERSION_MASK) returns the hex version like 0x0800, is it fine if I just print it out like that?

The version will be vm.j2seVersion().bitAnd(J2SE_VERSION_MASK).shiftRight(J2SE_JAVA_SPEC_VERSION_SHIFT).

We should probably arrange that those constants are available via generated DDR code. It could be that only a DDR annotation is required in j2sever.h.

keithc-ca · 2018-06-04T13:58:41Z

debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/JavaVersionHelper.java

+		UDATA javaVersion =  vm.j2seVersion().bitAnd(J2SE_SERVICE_RELEASE_MASK);
+		if (javaVersion.lt(J2SE_19)) {
+			out.printf("This command only works with Java version 9 or higher\n"
+					+ "The current Java version is: %s\n", convertVersionToString(javaVersion.intValue()));


The message should make it clearer that it's the version of the VM that created the core file being examined that is relevant (not the SDK being used to examine that core file).

keithc-ca · 2018-06-04T13:59:51Z

debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/JavaVersionHelper.java

+		return true;
+	}
+
+	private static String convertVersionToString(int version)


This should also be generalized so it won't need attention with each Java version.

keithc-ca · 2018-06-04T14:02:10Z

...tools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindAllModulesCommand.java

+					if (ObjectModel.isPointerInHeap(vm, moduleNameObjPtr)) {
+						String moduleName = J9ObjectHelper.stringValue(moduleNameObjPtr);
+						String hexAddress = modulePtr.getHexAddress();
+						out.printf("%s			!j9module %s\n", moduleName, hexAddress);


Strings should not have internal tabs; a better solution would be to use %-20s (or other suitable width).

keithc-ca · 2018-06-04T14:02:40Z

...tools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindAllModulesCommand.java

+					 * iterator checks on the region and make sure that it is
+					 * pointing to a module. (For modules, the first field must be
+					 * in heap since it is an object while for j9package it is a
+					 * J9UTF8)


Nit: Please finish the sentence with a period.

keithc-ca · 2018-06-04T14:05:17Z

...ols/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindModuleByNameCommand.java

+				J9ObjectPointer moduleNameObjPtr = null;
+				PatternString pattern = new PatternString(searchModuleName);
+
+				out.println(String.format("Searching for modules named '%1$s' in VM=%2$s", searchModuleName,


Why use %$1s instead of just %s? The former is only helpful when arguments are used out of order or are used repeatedly.

keithc-ca · 2018-06-04T14:05:35Z

...ols/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindModuleByNameCommand.java

+		}
+	}
+
+	/**


Nit: Formatting and inconsistent indenting.

I don't understand what the indentation issue is here..

It looks good now, so whatever I was commenting about has been addressed.

keithc-ca · 2018-06-04T14:07:11Z

debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/gccheck/CheckEngine.java

+			/* Even if hrm is null, all helpers that use it will null check it and attempt to allocate it and handle the failure */
+			MM_HeapRegionManagerPointer hrmPtr = MM_GCExtensionsPointer.cast(_javaVM.gcExtensions()).heapRegionManager();
+			_hrm = GCHeapRegionManager.fromHeapRegionManager(hrmPtr);
+		} catch (CorruptDataException cde) {}


This exception ought not to be ignored: I expect many NullPointerExceptions or similar problems if _hrm is null.

keithc-ca · 2018-06-05T13:22:41Z

...ols/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindModuleByNameCommand.java

+		}
+	}
+
+	/**


It looks good now, so whatever I was commenting about has been addressed.

keithc-ca · 2018-06-05T13:24:17Z

...ols/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindModuleByNameCommand.java

+
+						String moduleName = J9ObjectHelper.stringValue(moduleNameObjPtr);
+						String hexAddress = modulePtr.getHexAddress();
+						out.printf("%-30s!j9module %s\n", moduleName, hexAddress);


There should be at least one space between %-30s and !j9module so a module name of 30 characters or more is still separated from the command. You should also use %n instead of \n.

keithc-ca · 2018-06-05T13:26:25Z

...tools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindAllModulesCommand.java

+					if (ObjectModel.isPointerInHeap(vm, moduleNameObjPtr)) {
+						String moduleName = J9ObjectHelper.stringValue(moduleNameObjPtr);
+						String hexAddress = modulePtr.getHexAddress();
+						out.printf("%-30s!j9module %s\n", moduleName, hexAddress);


Please add a space between the fields and use %n for the line-end.

keithc-ca · 2018-06-05T13:28:19Z

...ols/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindModuleByNameCommand.java

+						out.printf("%-30s!j9module %s\n", moduleName, hexAddress);
+					}
+				}
+				out.println(String.format("Found %d module(s) named %s", hitCount, searchModuleName));


Please replace %s with '%s' for consistency with earlier message.

keithc-ca · 2018-06-05T13:29:32Z

...ols/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindModuleByNameCommand.java

+	 */
+	private void printUsage(PrintStream out) 
+	{
+		out.println("findmodulebyname <moduleName> - find the module corresponding to its module name");


The help and this usage message should make it clear that the argument is a name pattern.

keithc-ca · 2018-06-07T21:33:17Z

debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/JavaVersionHelper.java

+		int javaVersion = vm.j2seVersion().bitAnd(J2SE_SERVICE_RELEASE_MASK).intValue() >> J2SE_JAVA_SPEC_VERSION_SHIFT;
+		if (javaVersion < J2SE_19) {
+			out.printf("This command only works with core file created by VM with Java version 9 or higher\n"
+					+ "The current VM Java version is: %s\n", javaVersion);


Please %n instead of \n.

Please replace the remaining \n with %n.

keithc-ca · 2018-06-07T21:34:44Z

...ols/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindModuleByNameCommand.java

+				J9ObjectPointer moduleNameObjPtr = null;
+				PatternString pattern = new PatternString(searchModuleName);
+
+				out.println(String.format("Searching for modules named '%s' in VM=%s", searchModuleName,


Please use printf (with %n) instead of println and format.

Please fix the other instance of this pattern.

keithc-ca · 2018-06-07T21:38:18Z

...ols/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindModuleByNameCommand.java

+	 */
+	private void printUsage(PrintStream out) 
+	{
+		out.println("findmodulebyname <moduleNamePattern> - find the module corresponding to its given name pattern (like 'java.base')");


The help can be improved, I suggest:

findmodulebyname - find the modules corresponding to a name pattern (e.g. 'java.*')

Notice it makes it clear that more than one module might be found and shows the form of pattern used (I assume 'java.' is the same as the Java pattern 'java..').

keithc-ca · 2018-06-07T21:39:02Z

...ols/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindModuleByNameCommand.java

+{
+	public FindModuleByNameCommand()
+	{
+		addCommand("findmodulebyname", "<moduleName>", "find the modules corresponding to its module name");


The help here should be similar to that displayed by the usage method below.

keithc-ca

Please address my most recent comments.

Signed-off-by: Charles_Zheng <Juntian.Zheng@ibm.com>

keithc-ca · 2018-06-11T19:43:38Z

jenkins test sanity plinux

tajila reviewed May 24, 2018

View reviewed changes

pshipton added jdk9 jdk10 comp:vm jdk11 labels May 24, 2018

dmitripivkine self-requested a review May 28, 2018 22:40

dmitripivkine approved these changes May 28, 2018

View reviewed changes

Ailloviee force-pushed the DDRCommands_v1 branch 2 times, most recently from 6ce3e24 to 794a26d Compare May 29, 2018 20:50

Ailloviee changed the title ~~Add new DDR commands for modularity~~ Add new DDR commands for modularity__Command 1 and 2 May 30, 2018

Ailloviee force-pushed the DDRCommands_v1 branch 2 times, most recently from c7dffa6 to 6cf6c22 Compare May 30, 2018 17:40

tajila reviewed May 30, 2018

View reviewed changes

Ailloviee force-pushed the DDRCommands_v1 branch 2 times, most recently from 6f70363 to a8df173 Compare May 30, 2018 19:18

tajila approved these changes May 30, 2018

View reviewed changes

keithc-ca self-assigned this May 31, 2018

keithc-ca requested changes May 31, 2018

View reviewed changes

Ailloviee force-pushed the DDRCommands_v1 branch from a8df173 to b2f42fd Compare May 31, 2018 14:21

Ailloviee force-pushed the DDRCommands_v1 branch 3 times, most recently from 29613cb to 6218399 Compare June 1, 2018 17:33

Ailloviee force-pushed the DDRCommands_v1 branch from 6218399 to ea64a71 Compare June 1, 2018 19:33

tajila reviewed Jun 1, 2018

View reviewed changes

Ailloviee force-pushed the DDRCommands_v1 branch from ea64a71 to 0d6b038 Compare June 1, 2018 20:32

keithc-ca requested changes Jun 4, 2018

View reviewed changes

Ailloviee force-pushed the DDRCommands_v1 branch 3 times, most recently from fb08b31 to 4d41e58 Compare June 4, 2018 17:54

keithc-ca requested changes Jun 5, 2018

View reviewed changes

Ailloviee force-pushed the DDRCommands_v1 branch 6 times, most recently from deba172 to 5568562 Compare June 7, 2018 15:24

Ailloviee mentioned this pull request Jun 7, 2018

Add test cases for the DDR commands_Command 1 and 2 #2120

Merged

keithc-ca requested changes Jun 7, 2018

View reviewed changes

Ailloviee force-pushed the DDRCommands_v1 branch from 5568562 to 6aff8eb Compare June 8, 2018 15:11

keithc-ca requested changes Jun 11, 2018

View reviewed changes

Add new DDR commands for modularity

a1a647c

Signed-off-by: Charles_Zheng <Juntian.Zheng@ibm.com>

Ailloviee force-pushed the DDRCommands_v1 branch from 6aff8eb to a1a647c Compare June 11, 2018 17:40

keithc-ca approved these changes Jun 11, 2018

View reviewed changes

keithc-ca merged commit d78af3b into eclipse-openj9:master Jun 12, 2018

This was referenced Jun 14, 2018

Add test cases for the DDR commands_Command 3.1 and 3.2 #2191

Merged

Add test cases for the DDR commands_Command 4 and 5 and 6 #2192

Merged

+              		}
+              	}
+              	 /**

Add new DDR commands for modularity__Command 1 and 2 #1987

Add new DDR commands for modularity__Command 1 and 2 #1987

Conversation

Ailloviee commented May 24, 2018 • edited Loading

tajila May 24, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tajila commented May 24, 2018

tajila commented May 24, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tajila commented May 25, 2018

Ailloviee commented May 25, 2018

dmitripivkine left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tajila commented May 30, 2018

keithc-ca left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ailloviee commented May 31, 2018

pshipton commented May 31, 2018 • edited Loading

tajila commented May 31, 2018

keithc-ca commented May 31, 2018

Ailloviee commented May 31, 2018

AdamBrousseau commented Jun 1, 2018

Ailloviee commented Jun 1, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

keithc-ca left a comment

Choose a reason for hiding this comment

keithc-ca commented Jun 11, 2018

Ailloviee commented May 24, 2018 •

edited

Loading

tajila May 24, 2018 •

edited

Loading

pshipton commented May 31, 2018 •

edited

Loading