Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for the DDR commands_Command 3.1 and 3.2 #2191

Merged
merged 1 commit into from
Aug 13, 2018

Conversation

Ailloviee
Copy link
Contributor

@Ailloviee Ailloviee commented Jun 14, 2018

Added test cases for !dumpmoduleexports and !dumpmodulereads.

Example output:

Testing: Run !dumpmoduleexports
Test start time: 2018/06/14 13:13:11 Eastern Standard Time
Running command: C:/bluebird/builds/bld_389348/wa6490/bin/jdmpview.exe -core j9core.dmp
Time spent starting: 4 milliseconds
Time spent executing: 3388 milliseconds
Test result: PASSED

Testing: Verify !dumpmoduleexports
Test start time: 2018/06/14 13:13:15 Eastern Standard Time
Running command: C:/bluebird/builds/bld_389348/wa6490/bin/jdmpview.exe -core j9core.dmp
Time spent starting: 3 milliseconds
Time spent executing: 3145 milliseconds
Test result: PASSED

Testing: Run !dumpmodulereads
Test start time: 2018/06/14 13:13:18 Eastern Standard Time
Running command: C:/bluebird/builds/bld_389348/wa6490/bin/jdmpview.exe -core j9core.dmp
Time spent starting: 3 milliseconds
Time spent executing: 3255 milliseconds
Test result: PASSED

Testing: Verify !dumpmodulereads
Test start time: 2018/06/14 13:13:21 Eastern Standard Time
Running command: C:/bluebird/builds/bld_389348/wa6490/bin/jdmpview.exe -core j9core.dmp
Time spent starting: 5 milliseconds
Time spent executing: 3167 milliseconds
Test result: PASSED

\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\
NOTE: This pull request depends on PR#1987 and PR#2021

@Ailloviee Ailloviee force-pushed the DDRTests_v2 branch 3 times, most recently from 75f6ab8 to fee0a6b Compare June 14, 2018 19:44
@tajila
Copy link
Contributor

tajila commented Jul 4, 2018

@Ailloviee can you rebase this on the latest openj9

@tajila
Copy link
Contributor

tajila commented Jul 19, 2018

@llxia can you please review

@llxia
Copy link
Contributor

llxia commented Jul 19, 2018

Added test cases for !dumppackageexports and !dumpmodulereads

I did not see test for dumppackageexports

@tajila
Copy link
Contributor

tajila commented Jul 19, 2018

dumppackageexports was renamed to dumpmoduleexports

@llxia
Copy link
Contributor

llxia commented Jul 19, 2018

LGTM. Please add description in commit msg.

@llxia
Copy link
Contributor

llxia commented Jul 19, 2018

  • Is DDR ready on win and aix? From the current playlist, the tests will not run on win, zos and aix.
    <platformRequirements>^os.zos,^os.win,^os.aix</platformRequirements>

  • just to double check, it is intended to add new tests for SE90?

@Ailloviee
Copy link
Contributor Author

Ailloviee commented Jul 19, 2018

@llxia
Copy link
Contributor

llxia commented Jul 19, 2018

If it is only a temporary exclude until DDR is ready on aix and zos , please add a comment in playlist.xml. In this way, we can easy enable the test on these platforms later. Thanks.

@Ailloviee
Copy link
Contributor Author

@llxia No DDR is not supported on aix or zos yet

@llxia
Copy link
Contributor

llxia commented Jul 23, 2018

Please add comment in playlist and ref #1511. Thanks

@Ailloviee Ailloviee force-pushed the DDRTests_v2 branch 2 times, most recently from 7222635 to 356044b Compare July 23, 2018 16:31
Added test cases for !dumpmoduleexports and !dumpmodulereads.

Example output:

Testing: Run !dumpmoduleexports
Test start time: 2018/06/14 13:13:11 Eastern Standard Time
Running command: C:/bluebird/builds/bld_389348/wa6490/bin/jdmpview.exe
-core j9core.dmp
Time spent starting: 4 milliseconds
Time spent executing: 3388 milliseconds
Test result: PASSED

Testing: Verify !dumpmoduleexports
Test start time: 2018/06/14 13:13:15 Eastern Standard Time
Running command: C:/bluebird/builds/bld_389348/wa6490/bin/jdmpview.exe
-core j9core.dmp
Time spent starting: 3 milliseconds
Time spent executing: 3145 milliseconds
Test result: PASSED

Testing: Run !dumpmodulereads
Test start time: 2018/06/14 13:13:18 Eastern Standard Time
Running command: C:/bluebird/builds/bld_389348/wa6490/bin/jdmpview.exe
-core j9core.dmp
Time spent starting: 3 milliseconds
Time spent executing: 3255 milliseconds
Test result: PASSED

Testing: Verify !dumpmodulereads
Test start time: 2018/06/14 13:13:21 Eastern Standard Time
Running command: C:/bluebird/builds/bld_389348/wa6490/bin/jdmpview.exe
-core j9core.dmp
Time spent starting: 5 milliseconds
Time spent executing: 3167 milliseconds
Test result: PASSED

Signed-off-by: Charles_Zheng <Juntian.Zheng@ibm.com>
@llxia
Copy link
Contributor

llxia commented Aug 2, 2018

Jenkins test extended win jdk10

@llxia
Copy link
Contributor

llxia commented Aug 2, 2018

Jenkins test extended xlinux jdk10

@llxia
Copy link
Contributor

llxia commented Aug 2, 2018

PR build failed:

Testing: Verify !dumpmoduleexports
Test start time: 2018/08/02 15:37:12 Coordinated Universal Time
Running command: /home/jenkins/workspace/PullRequest-Extended-JDK10-linux_x86-64_cmprssptrs-OpenJ9/build/linux-x86_64-normal-server-release/images/jdk/bin/../bin/jdmpview -core j9core.dmp
Time spent starting: 3 milliseconds
Time spent executing: 4407 milliseconds
Test result: FAILED
 [OUT] DTFJView version 4.29.5, using DTFJ version 1.12.29003
 [OUT] Loading image from DTFJ...
 [OUT] 
 [OUT] For a list of commands, type "help"; for how to use "help", type "help help"
 [OUT] Available contexts (* = currently selected context) : 
 [OUT] 
 [OUT] Source : file:///home/jenkins/workspace/PullRequest-Extended-JDK10-linux_x86-64_cmprssptrs-OpenJ9/openj9/test/TestConfig/test_output_15332213494786/cmdLineTester_modularityddrtests_1/j9core.dmp
 [OUT] 	*0 : PID: 5377 : JRE 10 Linux amd64-64 (build 10.0.2-internal+0-adhoc.jenkins.PullRequest-Extended-JDK10-linuxx86-64cmprssptrs-OpenJ9)
 [OUT] 
 [OUT] > J9Package at 0x7f339807e3c0 {
 [OUT]   Fields for J9Package:
 [OUT] 	0x0: struct J9UTF8* packageName = !j9utf8 0x00007F33982A5230
 [OUT] 	0x8: BOOLEAN exportToAll = !j9x 0x7f339807e3c8
 [OUT] 	0xc: BOOLEAN exportToAllUnnamed = !j9x 0x7f339807e3cc
 [OUT] 	0x10: struct J9Module* module = !j9module 0x00007F339807D568
 [OUT] 	0x18: struct J9HashTable* exportsHashTable = !j9hashtable 0x00007F33982A5290
 [OUT] 	0x20: struct J9ClassLoader* classLoader = !j9classloader 0x00007F339807C428
 [OUT] }
 [OUT] > 
>> Success condition was found: [Output match: Fields for J9Package:]
>> Required condition was found: [Output match: packageName]
>> Required condition was not found: [Output match: jdk/internal/vm]
>> Required condition was found: [Output match: module]
>> Required condition was found: [Output match: exportsHashTable]
>> Failure condition was not found: [Output match: DDRInteractiveCommandException]
>> Failure condition was not found: [Output match: <FAULT>]

@Ailloviee
Copy link
Contributor Author

Ailloviee commented Aug 2, 2018

Sorry, this pr should also depend on #2192 where I made changes to add print names to !j9package and !j9module. The test failed here because the names are not printed

@llxia
Copy link
Contributor

llxia commented Aug 2, 2018

#2192 should not contain same set of tests of #2191. You cannot have both PRs for adding the same tests.

@Ailloviee
Copy link
Contributor Author

@llxia Sorry I meant that it depended on #2058 instead of
#2191

@llxia
Copy link
Contributor

llxia commented Aug 13, 2018

Jenkins test extended xlinux jdk10

@llxia
Copy link
Contributor

llxia commented Aug 13, 2018

Jenkins test extended win jdk10

1 similar comment
@llxia
Copy link
Contributor

llxia commented Aug 13, 2018

Jenkins test extended win jdk10

@llxia llxia merged commit 2572f4f into eclipse-openj9:master Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants