WIP: Archive test_output folder if build 'UNSTABLE' #1882

smlambert · 2018-05-10T01:11:28Z

If tests fail, we archive the test output, which will include test results, gc logs, and other test artifacts.
[ci skip]
Signed-off-by: smlambert slambert@gmail.com

- Add Windows variables - Add to nightly build - Add PullRequest Builds - Update README [skip ci] Issue eclipse-openj9#1662 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>

gcc-7.3 issues -Werror=unused-const-variable= error for j9_threadCleanup and j9_cleanup. Removed unused constants j9_threadCleanup and j9_cleanup to allow compilation with gcc-7.3. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>

J9VMThreadPointerUtil.getJ9State() was copied from thrinfo.c but is missing some checks. This can lead to a NULL pointer dereference, causing a CorruptDataException to be thrown. Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>

Signed-off-by: smlambert <slambert@gmail.com>

Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>

[skip ci] Issue eclipse-openj9#1873 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>

Limit variable lifetimes to smallest enclosing scope

Avoid NULL dereference in DTFJ

It relied on API [Thread.stop(Throwable)] that has long since been deprecated (and marked for removal starting with Java 9); there's no practical replacement implementation strategy. Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>

smlambert · 2018-05-10T14:32:57Z

@AdamBrousseau - if I wish to test a change to pipelines, do I need to setup a special build (that uses my branch)? If so, which sandbox build is best for me to copy from when I create it?

AdamBrousseau

To test this simply launch a PR build. The build will use your files.

AdamBrousseau · 2018-05-10T14:35:25Z

buildenv/jenkins/common/test

@@ -96,6 +96,12 @@ def publish() {
            junit allowEmptyResults: true, keepLongStdio: true, testResults: '**/junitreports/**/*.xml'
            step([$class: 'Publisher', reportFilenamePattern: '**/testng-results.xml'])
            step([$class: "TapPublisher", testResults: "**/*.tap"])
+            withEnv(["WORKSPACE=${WORKSPACE}", "currentBuild=${currentBuild}"]) { 


You shouldn't need this line

ok, thanks, and yes, wondered as they are both global...

…_to_nightly Add JenkinsFiles for Windows

check if the return value is BCT_ERR_OUT_OF_ROM and return the error to increase buffer size rather than marking annotation as malformed. Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>

OpenJ9 builds are normally configured on a host compatible with the target; only apply 'OMR_CROSS_CONFIGURE=yes' for use on J9 VMFarm machines (when CALLED_BY_SOURCE_ZIP is 'yes'). Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>

gcc-7.3 issues -Werror=unused-const-variable= error for MAGENTA, BLUE, YELLOW, GREEN and RED in linearswalk.c. Removed unused constants MAGENTA, BLUE, YELLOW, GREEN and RED in linearswalk.c to allow compilation with gcc-7.3. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>

Added spaces between literal and string macro to allow compilation with gcc-7.3. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>

Removed unused constants within jvmtiExtensionMechanism.c to allow compilation with gcc-7.3. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>

Buffer size doubled for actualCacheDir in order to prevent -Werror=format-overflow= error while compiling with gcc-7.3. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>

This docker file can be used to build JDK11 using OpenJ9. It installs gcc-7.3 and g++7.3 for building JDK11. Currently, no JDK10 with OpenJ9 releases are available at AdoptOpenJDK. So, the AdoptOpenJDK API can't be used to download a boot JDK. So, a nightly JDK10 OpenJ9 build is currently used as the boot JDK. Once JDK10 OpenJ9 releases are available, the following link can be used to download the JDK10 OpenJ9 boot JDK: https://api.adoptopenjdk.net/openjdk10-openj9/releases/x64_linux/latest/binary. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>

Signed-off-by: smlambert <slambert@gmail.com>

smlambert · 2018-05-10T20:39:30Z

Jenkins test sanity jdk8 plinux

smlambert · 2018-05-10T20:40:56Z

Jenkins test sanity plinux jdk8

software-properties-common and python-software-properties are only needed to install add-apt-repository. add-apt-repository is not used to add a repository. so, software-properties-common and python-software-properties dependencies have been removed. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>

Several random printf's in escape analysis are turned on by traceEscapeAnalysis. Change them to match the other tracing messages in this opt (traceMsg by default with a commented out printf in case someone wants/needs stdout). Signed-off-by: Mark Stoodley <mstoodle@ca.ibm.com>

- check nested critical first to avoid atomic - atomic-free expects VM access to be held - enter/exit VM are aliased to acquire/release VM access in the old VM Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>

…mmand Remove DDR interactive 'limit' command

Signed-off-by: smlambert <slambert@gmail.com>

smlambert · 2018-05-11T00:00:38Z

Jenkins test sanity plinux jdk8

…b14_dockerfile Update Dockerfile for Ubuntu16 JDK8 s390x

Cleanup Java source code

…gure Set OMR_CROSS_CONFIGURE properly

smlambert · 2018-05-11T03:15:39Z

Jenkins test extended plinux jdk8

- Speeds up OpenJDK clone - Allows for full cleanWs at the end of all builds - Won't fail if ref repo does not exist - Ref repo defined in variables file - Ref repo is a bare clone of extensions repos - Supports multiple ref repos in a single folder [skip ci] Fixes eclipse-openj9#1727 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>

Add reference repository to OpenJDK clone

OpenJ9 changes to build with gcc-7.3

…no_printf_by_default Change printf tracing statements in escape analysis to traceMsg's

smlambert · 2018-05-11T12:37:50Z

Jenkins test extended plinux jdk8

Signed-off-by: smlambert <slambert@gmail.com>

smlambert · 2018-05-11T14:58:35Z

Jenkins test extended plinux jdk9

Atomic-free JNI work

Fix result check on readAnnotations(...)

- Set initial index to 0 instead of -1 - Move counter increment to after decoding each frame Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>

The version of libffi used in OpenJ9 is only linked by the VM library, so make libffi a static link library instead of dynamic to avoid issues where another version of libffi has already been loaded into the process. Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>

smlambert · 2018-05-12T03:03:33Z

@AdamBrousseau - have you seen this error before?

groovy.lang.MissingPropertyException: No such property: test_target for class: groovy.lang.Binding
at groovy.lang.Binding.getVariable(Binding.java:63)

I have introduced an error in extended tests to verify that the archive of test_output_xxxx folder works if UNSTABLE, but this is a script failure that is unclear to me what is causing it? From what I can tell, test_target should be _extended.

AdamBrousseau · 2018-05-12T03:41:40Z

test_target should be TEST_TARGET :)

Fix stackMapFrame index init value and increment

Signed-off-by: smlambert <slambert@gmail.com>

smlambert · 2018-05-13T03:40:24Z

Jenkins test extended plinux jdk9

Signed-off-by: smlambert <slambert@gmail.com>

Turn libffi into a static link library

smlambert · 2018-05-14T03:38:03Z

Jenkins test extended plinux jdk9

Signed-off-by: smlambert <slambert@gmail.com>

…gcLog1470

AdamBrousseau and others added 9 commits May 3, 2018 12:05

Add JenkinsFiles for Windows

3212bec

- Add Windows variables - Add to nightly build - Add PullRequest Builds - Update README [skip ci] Issue eclipse-openj9#1662 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>

Remove unused class com.ibm.j9.uma.util.Tree

2f31cbe

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>

Fix uses of deprecated constructors for box types

428a323

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>

Avoid NULL dereference in DTFJ

d0a358f

J9VMThreadPointerUtil.getJ9State() was copied from thrinfo.c but is missing some checks. This can lead to a NULL pointer dereference, causing a CorruptDataException to be thrown. Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>

Archive test_output folder if build 'UNSTABLE'

7fbd4e8

Signed-off-by: smlambert <slambert@gmail.com>

Limit variable lifetimes to smallest enclosing scope

e8cafbc

Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>

Add ref_repo variable for Windows

91d2a83

[skip ci] Issue eclipse-openj9#1873 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>

Merge pull request eclipse-openj9#1883 from DanHeidinga/djh/scope

ffda2cb

Limit variable lifetimes to smallest enclosing scope

pshipton added the comp:test label May 10, 2018

DanHeidinga and others added 2 commits May 10, 2018 09:19

Merge pull request eclipse-openj9#1881 from gacholio/master

e11f730

Avoid NULL dereference in DTFJ

Remove DDR interactive 'limit' command

771c253

It relied on API [Thread.stop(Throwable)] that has long since been deprecated (and marked for removal starting with Java 9); there's no practical replacement implementation strategy. Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>

smlambert self-assigned this May 10, 2018

AdamBrousseau reviewed May 10, 2018

View reviewed changes

pshipton and others added 9 commits May 10, 2018 11:19

Merge pull request eclipse-openj9#1778 from AdamBrousseau/add_windows…

bd106f7

…_to_nightly Add JenkinsFiles for Windows

Fix result check on readAnnotations(...)

8057bde

check if the return value is BCT_ERR_OUT_OF_ROM and return the error to increase buffer size rather than marking annotation as malformed. Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>

Set OMR_CROSS_CONFIGURE properly

c07b038

OpenJ9 builds are normally configured on a host compatible with the target; only apply 'OMR_CROSS_CONFIGURE=yes' for use on J9 VMFarm machines (when CALLED_BY_SOURCE_ZIP is 'yes'). Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>

Added spaces between literal and string macro

7c54f46

Added spaces between literal and string macro to allow compilation with gcc-7.3. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>

Removed unused constants within jvmtiExtensionMechanism.c

e126035

Removed unused constants within jvmtiExtensionMechanism.c to allow compilation with gcc-7.3. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>

Increased buffer size for actualCacheDir

0b94de7

Buffer size doubled for actualCacheDir in order to prevent -Werror=format-overflow= error while compiling with gcc-7.3. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>

Remove withEnv wrap

a0bb563

Signed-off-by: smlambert <slambert@gmail.com>

babsingh and others added 4 commits May 10, 2018 17:35

Atomic-free JNI work

44208b5

- check nested critical first to avoid atomic - atomic-free expects VM access to be held - enter/exit VM are aliased to acquire/release VM access in the old VM Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>

Merge pull request eclipse-openj9#1887 from keithc-ca/remove-limit-co…

6bca16f

…mmand Remove DDR interactive 'limit' command

Add failure to test archive - tmp

a035856

Signed-off-by: smlambert <slambert@gmail.com>

pshipton added 3 commits May 10, 2018 22:01

Merge pull request eclipse-openj9#1893 from babsingh/fix_jdk8_s390x_u…

80539e5

…b14_dockerfile Update Dockerfile for Ubuntu16 JDK8 s390x

Merge pull request eclipse-openj9#1874 from keithc-ca/cleanup

7af3f58

Cleanup Java source code

Merge pull request eclipse-openj9#1891 from keithc-ca/fix-cross-confi…

d70c31d

…gure Set OMR_CROSS_CONFIGURE properly

AdamBrousseau and others added 4 commits May 10, 2018 23:30

Merge pull request eclipse-openj9#1873 from AdamBrousseau/ref_repo

cff1746

Add reference repository to OpenJDK clone

Merge pull request eclipse-openj9#1890 from babsingh/jdk11_gcc73

496353b

OpenJ9 changes to build with gcc-7.3

Merge pull request eclipse-openj9#1894 from mstoodle/trace_output_ea_…

c051630

…no_printf_by_default Change printf tracing statements in escape analysis to traceMsg's

Run TestExample for all linux

3af2b58

Signed-off-by: smlambert <slambert@gmail.com>

DanHeidinga and others added 4 commits May 11, 2018 13:35

Merge pull request eclipse-openj9#1895 from gacholio/master

04e85e7

Atomic-free JNI work

Merge pull request eclipse-openj9#1880 from fengxue-IS/longAnnotation

31c9646

Fix result check on readAnnotations(...)

Fix stackMapFrame index init value and increment

d9f526d

- Set initial index to 0 instead of -1 - Move counter increment to after decoding each frame Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>

gacholio and others added 2 commits May 12, 2018 17:56

Merge pull request eclipse-openj9#1903 from fengxue-IS/errorMsg

0df5a11

Fix stackMapFrame index init value and increment

Use correct TEST_TARGET var

b33a4d7

Signed-off-by: smlambert <slambert@gmail.com>

smlambert and others added 2 commits May 13, 2018 21:21

Rename archive

15ad326

Signed-off-by: smlambert <slambert@gmail.com>

Merge pull request eclipse-openj9#1900 from gacholio/staticffi

3a13d0e

Turn libffi into a static link library

smlambert added 2 commits May 13, 2018 23:44

Archive test output if test build unstable

c447ae4

Signed-off-by: smlambert <slambert@gmail.com>

Merge branch 'gcLog1470' of https://github.com/smlambert/openj9 into …

286e690

…gcLog1470

smlambert closed this May 14, 2018

smlambert deleted the gcLog1470 branch May 14, 2018 04:03

smlambert mentioned this pull request May 14, 2018

Archive test results if build UNSTABLE #1908

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Archive test_output folder if build 'UNSTABLE' #1882

WIP: Archive test_output folder if build 'UNSTABLE' #1882

smlambert commented May 10, 2018 •

edited

Loading

smlambert commented May 10, 2018

AdamBrousseau left a comment

AdamBrousseau May 10, 2018

smlambert May 10, 2018

smlambert commented May 10, 2018

smlambert commented May 10, 2018

smlambert commented May 11, 2018

smlambert commented May 11, 2018

smlambert commented May 11, 2018

smlambert commented May 11, 2018

smlambert commented May 12, 2018

AdamBrousseau commented May 12, 2018

smlambert commented May 13, 2018

smlambert commented May 14, 2018

WIP: Archive test_output folder if build 'UNSTABLE' #1882

WIP: Archive test_output folder if build 'UNSTABLE' #1882

Conversation

smlambert commented May 10, 2018 • edited Loading

smlambert commented May 10, 2018

AdamBrousseau left a comment

Choose a reason for hiding this comment

AdamBrousseau May 10, 2018

Choose a reason for hiding this comment

smlambert May 10, 2018

Choose a reason for hiding this comment

smlambert commented May 10, 2018

smlambert commented May 10, 2018

smlambert commented May 11, 2018

smlambert commented May 11, 2018

smlambert commented May 11, 2018

smlambert commented May 11, 2018

smlambert commented May 12, 2018

AdamBrousseau commented May 12, 2018

smlambert commented May 13, 2018

smlambert commented May 14, 2018

smlambert commented May 10, 2018 •

edited

Loading