Turn libffi into a static link library #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins compile all jdk8 |
DanHeidinga
changed the title
|
Marking this as WIP due to extra testing required - particularly on zOS. |
The version of libffi used in OpenJ9 is only linked by the VM library, so make libffi a static link library instead of dynamic to avoid issues where another version of libffi has already been loaded into the process. Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
|
Tested as much as possible with the current infra issues. Z/OS not tested at all, but there's no reason to think it's any different than the rest. |
|
There is an awful and fragile workaround here which will hopefully only live for a few days. The open builds scripts need to stop referring to the ffi shared library in any way - at that point I will remove the workaround. |
gacholio
changed the title
|
jenkins test sanity all jdk8 |
dnakamura
added a commit
to dnakamura/openj9
that referenced
this pull request
Nov 13, 2018
This is inline with changes already made to UMA. See eclipse-openj9#1900 Signed-off-by: Devin Nakamura <devinn@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of libffi used in OpenJ9 is only linked by the VM library,
so make libffi a static link library instead of dynamic to avoid issues
where another version of libffi has already been loaded into the
process.
Signed-off-by: Graham Chapman graham_chapman@ca.ibm.com