Prepare for value objects to be created with new bytecode #18790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change sets up changes to the JIT compiler that will be needed to permit value objects to be created with the new bytecode. Previously they could only be created with the aconst_init and withfield bytecode instructions. The new bytecode will be translated to the TR::New opcode in IL, but existing optimizations that create value type instances will continue to use the TR::newvalue opcode, so optimizations need to be prepared for both possibilities for now. A new J9::ObjectModel::areValueTypeInstancesCreatedWithBCNew method is used to enable creation of value type instances with the new bytecode.
hzongaro
added
comp:jit
depends:omr
|
I will leave this pull request in draft state for now, as it depends upon JVM changes that are part of pull request #18558. Further, the implementation of J9::ObjectModel::areValueTypeInstancesCreatedWithBCNew currently returns false unconditionally. It will need to be updated to return true once the |
|
@a7ehuo - FYI |
|
Superseded by pull request #19812 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change sets up changes to the JIT compiler that will be needed to permit value objects to be created with the
newbytecode. Previously they could only be created with theaconst_initandwithfieldbytecode instructions. Thenewbytecode will be translated to theTR::Newopcode in IL, but existing optimizations that create value type instances will continue to use theTR::newvalueopcode, so optimizations need to be prepared for both possibilities for now.A new
J9::ObjectModel::areValueTypeInstancesCreatedWithBCNewmethod is used to enable creation of value type instances with the new bytecode.This change will require a co-ordinated merge with OMR pull request eclipse-omr/omr#7239