Allow Value Propagation to remove TR::new that creates a value type instance #7239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, value type instances created with the jitNewObject helper in a TR::new operation would result in an InstantiationError. That prevented Value Propagation from removing a TR::new operation that was known to create an instance of a value type. This change prepares for the possibility that a TR::new with a jitNewObject helper could be used to create an instance of a value type, which means the operation need not be kept just to allow for an InstantiationError to be thrown. Whether a TR::new with jitNewObject can be used to create a value type instance is indicated by the method ObjectModel method OMR::ObjectModel::areValueTypeInstancesCreatedWithBCNew. The default implementation returns false, but downstream uses might override that implementation.
|
I will leave this pull request in draft state for now, as the corresponding pull request in downstream project OpenJ9 depends upon pull request eclipse-openj9/openj9#18558. |
|
@a7ehuo - FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, value type instances created with the jitNewObject helper in a
TR::newoperation would result in anInstantiationError. That prevented Value Propagation from removing aTR::newoperation that was known to create an instance of a value type. This change prepares for the possibility that aTR::newwith ajitNewObjecthelper could be used to create an instance of a value type, which means the operation need not be kept just to allow for anInstantiationErrorto be thrown.Whether a
TR::newwithjitNewObjectcan be used to create a value type instance is indicated by the method ObjectModel methodOMR::ObjectModel::areValueTypeInstancesCreatedWithBCNew. The default implementation returns false, but downstream uses might override that implementation.This pull request will require a co-ordinated merge with OpenJ9 pull request eclipse-openj9/openj9#18790