Relocate the rates calculating on the first PGC After GMP #1175
Conversation
There was a problem hiding this comment.
https://github.com/eclipse/openj9/blob/master/CONTRIBUTING.md#commit-guidelines
The first line should be less than 70 characters, where reasonable, and should be written in sentence case ...
Note that both the commit and the pull request should be modified, i.e. aaa4b22 needs a change as well.
LinHu2016
changed the title
LinHu2016
changed the title
LinHu2016
force-pushed
the
fix_compact_regression
branch
from
aaa4b22 to
4290076
Compare
|
there is a dependence of the omr change(eclipse-omr/omr#2350) |
fjeremic
added
the
depends:omr
- recalculating PGCCompactionRate, HeapOccupancyTrend, ScannableBytesRatio after PGC and before estimating defragmentReclaimableRegions for calculating GMPIntermission and desiredCompactWork accurate. - update calculatePGCCompactionRate tracepoint for provide more detail information. Signed-off-by: Lin Hu <linhu@ca.ibm.com>
LinHu2016
force-pushed
the
fix_compact_regression
branch
from
4290076 to
e0b26f1
Compare
|
OMR Acceptance builds are blocked on acceptance of this change. jenkins test sanity plinux depends eclipse-omr/omr#2350 |
|
@AdamBrousseau is there a problem with including dependent changes? |
|
The OMR PR s already merged so the "merge" ref does not exist anymore. See #827 for more info. |
|
@dmitripivkine @charliegracie @amicic Can one of you review and merge the GC changes here? The OMR integration build is broken until this is merged. |
|
I reviewed the failures in travis build, and they seem to be due to missing dependant OMR change that is already merged. I'm merging this despite the travis failures, since I know that Lin did a lot of testing locally with this changes. |
recalculating PGCCompactionRate, HeapOccupancyTrend,
ScannableBytesRatio after PGC and before estimating
defragmentReclaimableRegions for calculating GMPIntermission
and desiredCompactWork accurate.
update calculatePGCCompactionRate tracepoint for provide more
detail information.
Signed-off-by: Lin Hu linhu@ca.ibm.com