Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR builds: Also support "depends" on a repo/branch #827

Closed
AdamBrousseau opened this issue Dec 14, 2017 · 2 comments
Closed

PR builds: Also support "depends" on a repo/branch #827

AdamBrousseau opened this issue Dec 14, 2017 · 2 comments
Labels
comp:build enhancement prio:high

Comments

@AdamBrousseau
Copy link
Contributor

AdamBrousseau commented Dec 14, 2017 •
edited
Loading

Currently we can launch PR builds with dependent changes that are in an open PR at omr, openj9-omr or openj9-openjdk-jdk9. There is a use case to launch a PR build against a branch instead of an open PR. For example, when the dependent or breaking PR has been merged in OMR and can't promote through OMR-Acceptance.

More info on dependent changes
https://github.com/eclipse/openj9/blob/master/buildenv/jenkins/README.md#dependent-changes

If we can temporarily survive without this feature, it would be nice to finish off #660, #851 first. Which will commit all the build code in.
@DanHeidinga
Copy link
Member

We've survived this long without it so I view as an enhancement. Delaying until those PRs are merged is fine as long we are able to close those out in a reasonable time frame

@AdamBrousseau AdamBrousseau mentioned this issue Jan 15, 2018
Closed
@AdamBrousseau AdamBrousseau mentioned this issue Mar 3, 2018
Merged
@DanHeidinga
Copy link
Member

Bumping the priority on this as we're seeing more OpenJ9 PRs with dependent OMR changes that can't be built as the OMR change has already been merged.

@AdamBrousseau AdamBrousseau mentioned this issue Mar 12, 2018
Merged
3 tasks
@AdamBrousseau AdamBrousseau mentioned this issue Apr 16, 2018
Merged
non-conformances-research pushed a commit to non-conformances-research/openj9 that referenced this issue Apr 27, 2018
@AdamBrousseau @non-conformances-research
Support PR dependent branches
e13ddff 
- Determine if dependent string is a PR or a branch
- Fetch & checkout proper ref accodingly.

[skip ci]

Fixes eclipse-openj9#827

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
AdamBrousseau added a commit to AdamBrousseau/openj9 that referenced this issue Jun 9, 2018
@AdamBrousseau
Update readme for dependent branches
2642c1a 
PullRequests support building with dependent changes
in branches now too. This is particularly useful
when you have an OMR change that was merged and
your change is dependent. Because the PR is merged,
you cannot build with the dependent PR because the
merge ref is removed when the PR is merged. The default
branch to build omr is openj9. If you build against
master, you will pickup the merged dependent PR.

Issue eclipse-openj9#827
Related eclipse-openj9#1698
[skip ci]

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
@AdamBrousseau AdamBrousseau mentioned this issue Jun 9, 2018
Merged
@AdamBrousseau AdamBrousseau mentioned this issue Jul 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:build enhancement prio:high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AdamBrousseau @DanHeidinga