-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RISC-V: add native build spec #7556
RISC-V: add native build spec #7556
Conversation
jenkins build riscv |
Looks like the container is missing git. I commented in the Eclipse issue. |
jenkins build riscv |
6b15486
to
6537581
Compare
jenkins build riscv |
@babsingh can you confirm if we need to change the |
It makes sense to differentiate between the two variants, i.e., include both |
6537581
to
3468d2e
Compare
jenkins build riscv |
3468d2e
to
62d4368
Compare
So you suggest to do the following? omr/buildenv/jenkins/omrbuild.groovy Lines 163 to 164 in 62d4368
and omr/buildenv/jenkins/omrbuild.groovy Lines 183 to 184 in 62d4368
|
Yes, just the aliases should differ for the two configurations. If you'd like, you can suggest shorter alias names. |
Looking at (failed) run 6 ( https://ci.eclipse.org/omr/job/PullRequest-linux_riscv64/6/console):
I'll have another look next week. |
jenkins build riscv |
1 similar comment
jenkins build riscv |
I think I was right. The build runs with core dump size hard limit set to 0, see https://ci.eclipse.org/omr/job/PullRequest-linux_riscv64/26/consoleFull (text-search for "ulimit"). I double checked: on my test docker image core dump tests pass if core file limit is at unlimited or 1MB and fail when set to zero. I think we need to open an issue with Eclipse CI to increase the limit for us. Or else, disable dump tests. |
I went ahead: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5370 |
jenkins build riscv |
jenkins build riscv |
This commit adds a RISC-V native build spec for CI testing. This is intended to run on Eclipse CBI [1]. [1]: https://github.com/eclipse-cbi/cbi/wiki#whats-provided
4a06bff
to
7059bfe
Compare
jenkins build riscv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm from build side.
The PR build failure is unrelated to the changes in this PR. It's a known issue, which is documented in #7181. @AdamBrousseau The riscv machines need a specific Python version, which supports |
Ok. In that case can @janvrany ask in the Eclipse Gitlab ticket for the version we need? |
#7576 tries to address the issue by replacing the usage of |
Personally, I'd very much prefer to avoid having custom version of Python. It is not readily available as package - not in Ubuntu, nor in Debian - so it would mean compiling our own and install it (maybe alongside packaged Python). Given that we do not manage the build agent image, feels like lot work not only for us, but also for Eclipse CI team. Let's wait for #7576 review and see. |
This PR adds a RISC-V native build spec in order to (re) enable OMR CI for RISC-V using RISC-V hardware.
For details see #7530.