Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename deprecated Python unittest function assertRegexpMatches #7279

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0xdaryl
Copy link
Contributor

@0xdaryl 0xdaryl commented Mar 1, 2024

assertRegexpMatches was renamed to assertRegex in Python 3.2 and was removed entirely in Python 3.10.

Our CI systems should all have at least Python 3.2. Rename uses to assertRegex.

Fixes: #7181

@0xdaryl
Copy link
Contributor Author

0xdaryl commented Mar 2, 2024

Jenkins build all

@0xdaryl 0xdaryl marked this pull request as draft March 2, 2024 02:55
`assertRegexpMatches` was renamed to `assertRegex` in Python 3.2 and has been
removed entirely in Python 3.10.

Our CI systems should all have at least Python 3.2.  Rename uses to `assertRegex`.

Fixes: eclipse-omr#7181

Signed-off-by: Daryl Maier <maier@ca.ibm.com>
@0xdaryl
Copy link
Contributor Author

0xdaryl commented May 24, 2024

Jenkins build all

I know this will fail. I just need to find out which platforms.

@janvrany
Copy link
Contributor

Jenkins build all

This will probably fail but I'd like to know what's the situation now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestJitBuilderAPIGenerator failure: no attribute assertRegexpMatches
2 participants