-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox #1036 in place creation for memory map #1041
Merged
elfenpiff
merged 8 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#1036-in-place-creation-for-memory-map
Jan 26, 2022
Merged
Iox #1036 in place creation for memory map #1041
elfenpiff
merged 8 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#1036-in-place-creation-for-memory-map
Jan 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rected const correctness Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…ilder patterns more easily and implemented MemoryMapBuilder with that Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
12 tasks
Signed-off-by: Christian Eltzschig <me@elchris.org>
Codecov Report
@@ Coverage Diff @@
## master #1041 +/- ##
==========================================
+ Coverage 77.21% 77.23% +0.02%
==========================================
Files 340 341 +1
Lines 12368 12380 +12
Branches 1841 1844 +3
==========================================
+ Hits 9550 9562 +12
+ Misses 2202 2197 -5
- Partials 616 621 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Christian Eltzschig <me@elchris.org>
elBoberido
reviewed
Jan 24, 2022
iceoryx_hoofs/include/iceoryx_hoofs/internal/posix_wrapper/shared_memory_object.hpp
Outdated
Show resolved
Hide resolved
iceoryx_hoofs/include/iceoryx_hoofs/internal/posix_wrapper/shared_memory_object/memory_map.hpp
Show resolved
Hide resolved
Signed-off-by: Christian Eltzschig <me@elchris.org>
319ffde
to
6d3c7eb
Compare
elBoberido
previously approved these changes
Jan 25, 2022
iceoryx_hoofs/include/iceoryx_hoofs/internal/posix_wrapper/shared_memory_object/memory_map.hpp
Show resolved
Hide resolved
iceoryx_hoofs/include/iceoryx_hoofs/internal/posix_wrapper/shared_memory_object/memory_map.hpp
Outdated
Show resolved
Hide resolved
iceoryx_hoofs/include/iceoryx_hoofs/internal/posix_wrapper/shared_memory_object/memory_map.hpp
Outdated
Show resolved
Hide resolved
… accessing baseAddressHint when the optional is not set Signed-off-by: Christian Eltzschig <me@elchris.org>
FerdinandSpitzschnueffler
approved these changes
Jan 26, 2022
elBoberido
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
The is the first of multiple PRs. The creation design pattern was removed for the memory map. Additionally, documentation was added and some enum to reduce misuse cases.
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References