Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox #1036 in place creation for memory map #1041

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Jan 24, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

The is the first of multiple PRs. The creation design pattern was removed for the memory map. Additionally, documentation was added and some enum to reduce misuse cases.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

…rected const correctness

Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…ilder patterns more easily and implemented MemoryMapBuilder with that

Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #1041 (36f3c2c) into master (771ad55) will increase coverage by 0.02%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1041      +/-   ##
==========================================
+ Coverage   77.21%   77.23%   +0.02%     
==========================================
  Files         340      341       +1     
  Lines       12368    12380      +12     
  Branches     1841     1844       +3     
==========================================
+ Hits         9550     9562      +12     
+ Misses       2202     2197       -5     
- Partials      616      621       +5     
Flag Coverage Δ
unittests 76.44% <70.00%> (+0.02%) ⬆️
unittests_timing 12.39% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eoryx_hoofs/include/iceoryx_hoofs/cxx/helplets.hpp 86.84% <ø> (ø)
...fs/internal/posix_wrapper/shared_memory_object.hpp 66.66% <ø> (ø)
...de/iceoryx_posh/internal/mepoo/segment_manager.hpp 100.00% <ø> (ø)
.../posix_wrapper/shared_memory_object/memory_map.cpp 36.08% <55.55%> (+2.10%) ⬆️
...oofs/source/posix_wrapper/shared_memory_object.cpp 80.55% <82.35%> (-2.78%) ⬇️
.../posix_wrapper/shared_memory_object/memory_map.hpp 100.00% <100.00%> (ø)
iceoryx_hoofs/source/concurrent/loffli.cpp 79.41% <0.00%> (-5.89%) ⬇️
iceoryx_hoofs/source/posix_wrapper/timer.cpp 63.29% <0.00%> (ø)

Signed-off-by: Christian Eltzschig <me@elchris.org>
@elfenpiff elfenpiff self-assigned this Jan 25, 2022
Signed-off-by: Christian Eltzschig <me@elchris.org>
@elfenpiff elfenpiff force-pushed the iox-#1036-in-place-creation-for-memory-map branch from 319ffde to 6d3c7eb Compare January 25, 2022 13:43
@elfenpiff elfenpiff requested a review from elBoberido January 25, 2022 14:04
elBoberido
elBoberido previously approved these changes Jan 25, 2022
… accessing baseAddressHint when the optional is not set

Signed-off-by: Christian Eltzschig <me@elchris.org>
@elfenpiff elfenpiff merged commit b64a4c0 into eclipse-iceoryx:master Jan 26, 2022
@elfenpiff elfenpiff deleted the iox-#1036-in-place-creation-for-memory-map branch January 26, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove creation design pattern class with in place implementation
3 participants