-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove creation design pattern class with in place implementation #1036
Closed
12 tasks done
Labels
globex
refactoring
Refactor code without adding features
technical debt
unclean code and design flaws
Milestone
Comments
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jan 24, 2022
…rected const correctness Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jan 24, 2022
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jan 24, 2022
…ilder patterns more easily and implemented MemoryMapBuilder with that Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jan 24, 2022
Signed-off-by: Christian Eltzschig <me@elchris.org>
21 tasks
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jan 24, 2022
Signed-off-by: Christian Eltzschig <me@elchris.org>
21 tasks
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jan 24, 2022
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jan 25, 2022
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jan 25, 2022
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jan 26, 2022
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jan 26, 2022
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jan 26, 2022
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jan 26, 2022
… accessing baseAddressHint when the optional is not set Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jan 26, 2022
… accessing baseAddressHint when the optional is not set Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jan 26, 2022
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jan 26, 2022
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jan 26, 2022
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jan 26, 2022
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jan 26, 2022
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
added a commit
that referenced
this issue
Jan 26, 2022
…memory-map Iox #1036 in place creation for memory map
21 tasks
elBoberido
added a commit
to elBoberido/iceoryx
that referenced
this issue
Sep 2, 2023
elBoberido
added a commit
to elBoberido/iceoryx
that referenced
this issue
Sep 2, 2023
elBoberido
added a commit
that referenced
this issue
Sep 4, 2023
…-message-queue iox-#1036 Builder pattern for message queue
elBoberido
added a commit
to elBoberido/iceoryx
that referenced
this issue
Sep 4, 2023
elBoberido
added a commit
to elBoberido/iceoryx
that referenced
this issue
Sep 4, 2023
elBoberido
added a commit
to elBoberido/iceoryx
that referenced
this issue
Sep 4, 2023
elBoberido
added a commit
to elBoberido/iceoryx
that referenced
this issue
Sep 4, 2023
elBoberido
added a commit
that referenced
this issue
Sep 4, 2023
…-named-pipe iox-#1036 builder pattern for named pipe
elBoberido
added a commit
to elBoberido/iceoryx
that referenced
this issue
Sep 4, 2023
elBoberido
added a commit
to elBoberido/iceoryx
that referenced
this issue
Sep 4, 2023
elBoberido
added a commit
to elBoberido/iceoryx
that referenced
this issue
Sep 4, 2023
elBoberido
added a commit
to elBoberido/iceoryx
that referenced
this issue
Sep 4, 2023
elBoberido
added a commit
to elBoberido/iceoryx
that referenced
this issue
Sep 4, 2023
This was
linked to
pull requests
Sep 4, 2023
elBoberido
added a commit
to elBoberido/iceoryx
that referenced
this issue
Sep 4, 2023
elBoberido
added a commit
to elBoberido/iceoryx
that referenced
this issue
Sep 4, 2023
elBoberido
added a commit
to elBoberido/iceoryx
that referenced
this issue
Sep 4, 2023
elBoberido
added a commit
to elBoberido/iceoryx
that referenced
this issue
Sep 4, 2023
elBoberido
added a commit
that referenced
this issue
Sep 4, 2023
…-unix-domain-socket iox-#1036 builder pattern for unix domain socket
21 tasks
elBoberido
added a commit
to elBoberido/iceoryx
that referenced
this issue
Sep 4, 2023
elBoberido
added a commit
to elBoberido/iceoryx
that referenced
this issue
Sep 4, 2023
elBoberido
added a commit
to elBoberido/iceoryx
that referenced
this issue
Sep 4, 2023
elBoberido
added a commit
to elBoberido/iceoryx
that referenced
this issue
Sep 4, 2023
elBoberido
added a commit
that referenced
this issue
Sep 6, 2023
…tern iox-#1036 remove creation pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
globex
refactoring
Refactor code without adding features
technical debt
unclean code and design flaws
Brief feature description
Inheriting from the creation design pattern class has certain drawbacks which can be very error prone.
m_isInitialized
,m_errorValue
are sometimes overlooked or not set correctlyA better implementation alternative would be to create a static method in such classes called
create
and create the system resource directly in there and provide the handle to that successfully created resource to the constructor of the class. The constructor does not create the system resource it just acquires a existing one and handles its lifetime.Another approach is to introduce a builder pattern when the class constructors requires more then zero arguments to improve the readability.
Classes where Creation pattern must be replaced with static create method
@todo iox-#1036
should be gonecreation.hpp
toiceoryx_dust
(high prio)The text was updated successfully, but these errors were encountered: