-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox #989 handle deserialization errors for publisher and subscriber options #1008
Merged
elBoberido
merged 8 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#989-handle-deserialization-errors-for-publisher-and-subscriber-options
Jan 10, 2022
Merged
Iox #989 handle deserialization errors for publisher and subscriber options #1008
elBoberido
merged 8 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#989-handle-deserialization-errors-for-publisher-and-subscriber-options
Jan 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67c711a
to
4e70862
Compare
Codecov Report
@@ Coverage Diff @@
## master #1008 +/- ##
==========================================
+ Coverage 77.57% 77.74% +0.17%
==========================================
Files 334 336 +2
Lines 12370 12362 -8
Branches 1840 1839 -1
==========================================
+ Hits 9596 9611 +15
+ Misses 2143 2126 -17
+ Partials 631 625 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FerdinandSpitzschnueffler
approved these changes
Jan 10, 2022
mossmaurice
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
The deserialization of the enum values are now also checked for validity and cxx::Serialization is used to serialize the options.
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References