Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox #989 handle deserialization errors for publisher and subscriber options #1008

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Jan 5, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

The deserialization of the enum values are now also checked for validity and cxx::Serialization is used to serialize the options.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added the bug Something isn't working label Jan 5, 2022
@elBoberido elBoberido self-assigned this Jan 5, 2022
@elBoberido elBoberido added bugfix Solves a bug and removed bug Something isn't working labels Jan 5, 2022
@elBoberido elBoberido force-pushed the iox-#989-handle-deserialization-errors-for-publisher-and-subscriber-options branch from 67c711a to 4e70862 Compare January 5, 2022 20:08
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #1008 (ebdeb84) into master (76ba504) will increase coverage by 0.17%.
The diff coverage is 82.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1008      +/-   ##
==========================================
+ Coverage   77.57%   77.74%   +0.17%     
==========================================
  Files         334      336       +2     
  Lines       12370    12362       -8     
  Branches     1840     1839       -1     
==========================================
+ Hits         9596     9611      +15     
+ Misses       2143     2126      -17     
+ Partials      631      625       -6     
Flag Coverage Δ
unittests 76.65% <82.60%> (+0.18%) ⬆️
unittests_timing 30.10% <0.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_posh/source/roudi/roudi.cpp 60.51% <50.00%> (+3.43%) ⬆️
iceoryx_posh/source/popo/publisher_options.cpp 100.00% <100.00%> (ø)
iceoryx_posh/source/popo/subscriber_options.cpp 100.00% <100.00%> (ø)
iceoryx_posh/source/runtime/posh_runtime_impl.cpp 65.17% <100.00%> (-0.55%) ⬇️
iceoryx_hoofs/source/posix_wrapper/timer.cpp 62.44% <0.00%> (-0.85%) ⬇️
iceoryx_hoofs/include/iceoryx_hoofs/cxx/string.hpp 100.00% <0.00%> (ø)
...eoryx_hoofs/include/iceoryx_hoofs/cxx/helplets.hpp 86.84% <0.00%> (ø)
...oofs/include/iceoryx_hoofs/internal/cxx/string.inl 99.09% <0.00%> (ø)
iceoryx_hoofs/source/concurrent/loffli.cpp 85.29% <0.00%> (+5.88%) ⬆️
...al/popo/building_blocks/chunk_distributor_data.inl 100.00% <0.00%> (+33.33%) ⬆️

Copy link
Contributor

@mossmaurice mossmaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elBoberido elBoberido merged commit effa1c8 into eclipse-iceoryx:master Jan 10, 2022
@elBoberido elBoberido deleted the iox-#989-handle-deserialization-errors-for-publisher-and-subscriber-options branch January 10, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Solves a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deserialization errors for publisher and subscriber options are not catched
3 participants