Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialization errors for publisher and subscriber options are not catched #989

Closed
elBoberido opened this issue Dec 13, 2021 · 0 comments · Fixed by #1008
Closed

Deserialization errors for publisher and subscriber options are not catched #989

elBoberido opened this issue Dec 13, 2021 · 0 comments · Fixed by #1008
Assignees
Labels
bug Something isn't working technical debt unclean code and design flaws

Comments

@elBoberido
Copy link
Member

Required information

The deserialization of the publisher and subscriber options don't handle invalid values for enums like SubscriberTooSlowPolicy correctly and the deserialized struct could end up with an invalid enum value.

Operating system:
all

Compiler version:
all

Observed result or behaviour:
An integer value is converted into an invalid enum value, e.g. 42 into an enum having only 0 or 1 as valid value

Expected result or behaviour:
Invalid values should be catched when deserialized

Conditions where it occurred / Performed steps:
Request a publisher port from RouDi and send e.g. 42 as value for the subscriberTooSlowPolicy.

@elBoberido elBoberido added bug Something isn't working technical debt unclean code and design flaws labels Dec 13, 2021
@elBoberido elBoberido self-assigned this Dec 13, 2021
@elBoberido elBoberido changed the title Deserialization errors for publisher and subscriber errors are not catched Deserialization errors for publisher and subscriber options are not catched Jan 5, 2022
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Jan 5, 2022
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Jan 5, 2022
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Jan 5, 2022
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Jan 5, 2022
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Jan 5, 2022
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Jan 5, 2022
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Jan 5, 2022
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Jan 10, 2022
elBoberido added a commit that referenced this issue Jan 10, 2022
…errors-for-publisher-and-subscriber-options

Iox #989 handle deserialization errors for publisher and subscriber options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working technical debt unclean code and design flaws
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant