Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove blinking warning in Roudi #85

Closed
Karsten1987 opened this issue Apr 14, 2020 · 4 comments · Fixed by #152
Closed

remove blinking warning in Roudi #85

Karsten1987 opened this issue Apr 14, 2020 · 4 comments · Fixed by #152

Comments

@Karsten1987
Copy link
Contributor

Karsten1987 commented Apr 14, 2020

The warning of Could not open file '/etc/iceoryx/roudi_config.toml'. is somewhat misleading as it doesn't give the user any more info about what's happening.

Not only does it (annoyingly) blink, the RouDi application runs perfectly fine.

If you look at the two warnings around that, I don't see why this warning has to be red and blinking:

2020-04-13 17:36:36.144 [ Info  ]: No config file provided. Using /etc/iceoryx/roudi_config.toml
Could not open file '/etc/iceoryx/roudi_config.toml'.
2020-04-13 17:36:36.144 [ Info  ]: No config file found at /etc/iceoryx/roudi_config.toml. Falling back to built-in config.
@evshary
Copy link
Contributor

evshary commented Apr 22, 2020

It seems like these info messages can't be hidden by running RouDi command like this RouDi -l off.
The reason might be that RouDi tries to get the config before setting log level.

BTW, I'm not sure why some message uses std:cerr instead of iceoryx log function. Is there any reason? (If it's off-topic, I can open another issue to discuss this.)

@budrus
Copy link
Contributor

budrus commented Apr 22, 2020

@evshary good point, I will open the issue. Different logger were used in the past. I guess a cleanup is needed. Sometimes a dependency to a logger in quite low layer modules in the utils was undesired. But there is no clear strategy now

@elBoberido
Copy link
Member

yes, this should not blink and also not be printed. It should just print which config is used.

@budrus
Copy link
Contributor

budrus commented Jun 8, 2020

i created a separate issue for the logger topic #130

elBoberido added a commit to elBoberido/iceoryx that referenced this issue Jun 23, 2020
Signed-off-by: Kraus Mathias (CC-AD/ESW1) <mathias.kraus2@de.bosch.com>
elBoberido added a commit that referenced this issue Jun 24, 2020
…-warning

iox-#85 remove blinking roudi warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants