Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger and error handling strategy #130

Closed
2 tasks done
budrus opened this issue Jun 8, 2020 · 3 comments
Closed
2 tasks done

Logger and error handling strategy #130

budrus opened this issue Jun 8, 2020 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@budrus
Copy link
Contributor

budrus commented Jun 8, 2020

Brief feature description

Having a clear strategy for logging and error handling

Detailed information

  • initial document for logging and error handling strategy

  • clarification of open points like error handling in utils

    • How to deal with terminate(), assert, expects() etc.?
@MatthiasKillat
Copy link
Contributor

While we have error-handling.md which summarizes our current error handling strategy and mentions open points (cf. #343)

How do specifically deal with errors in iceoryx::utils is not addressed in much detail there (we have yet to find a clear strategy for this).

@budrus
I propose to leave this issue open but maybe rename the issue to Logger and error handling strategy in iceoryx::utils.

Even if we do not want to do this, we have not yet verified that all methods are indeed noexcept.

@budrus
Copy link
Contributor Author

budrus commented Nov 18, 2020

@MatthiasKillat OK, but this is then no more a topic for the 1.0 release. I will update the description

@mossmaurice
Copy link
Contributor

How to deal with terminate(), assert, expects() etc.?

This is solved in the error handling document.

Do not use std::terminate directly but use assert-like constructs such as Expects or Ensures.

Hence, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants