Refactor DI multibinding approach #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tortmayr
commented
Jan 22, 2020
tortmayr
commented
- Introduce new helper class for easier configuration of multi bindings (add,remove,rebind)
- Remove ActionProvider and bind Action classes directly via multi bind
- Introduce InstanceRegistry (client side already has a similar concept)
- Refactor ActionRegistry to make use of the new InstanceRegistry
- Move multibinding default values into dedicated util class
|
see also: eclipse-glsp/glsp-examples#30 |
tortmayr
force-pushed
the
tortmayr/refactor-di
branch
from
56fcff7 to
d5f7dd0
Compare
tortmayr
changed the title
tortmayr
changed the title
martin-fleck-at
approved these changes
Jan 27, 2020
- Introduce new helper class for easier configuration of multi bindings (add,remove,rebind) - Remove ActionProvider and bind Action classes directly via multi bind - Introduce InstanceRegistry (client side already has a similar concept) - Refactor ActionRegistry to make use of the new InstanceRegistry - Move multibinding default values into dedicated util class
tortmayr
force-pushed
the
tortmayr/refactor-di
branch
from
d5f7dd0 to
dec64d9
Compare
tortmayr
added a commit
that referenced
this pull request
Jan 27, 2020
- Introduce new helper class for easier configuration of multi bindings (add,remove,rebind) - Remove ActionProvider and bind Action classes directly via multi bind - Introduce InstanceRegistry (client side already has a similar concept) - Refactor ActionRegistry to make use of the new InstanceRegistry - Move multibinding default values into dedicated util class
MatthiasHofstaetter
pushed a commit
to MatthiasHofstaetter/glsp-server
that referenced
this pull request
Dec 21, 2024
- Introduce new helper class for easier configuration of multi bindings (add,remove,rebind) - Remove ActionProvider and bind Action classes directly via multi bind - Introduce InstanceRegistry (client side already has a similar concept) - Refactor ActionRegistry to make use of the new InstanceRegistry - Move multibinding default values into dedicated util class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.