Update DI module after API changes #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tortmayr
force-pushed
the
tortmayr/di-refactor
branch
from
631d19b to
4e19ae0
Compare
martin-fleck-at
requested changes
Jan 27, 2020
There was a problem hiding this comment.
Change looks good to me, so thank you for your work! I just have two minor points:
- Please remove the auto-generated comments.
- I had to delete and re-generate my yarn.lock and it shows some changes, could you please update the yarn.lock for this commit as well? Thanks!
|
|
||
| @Override | ||
| protected Class<? extends ServerCommandHandlerProvider> bindServerCommandHandlerProvider() { | ||
| // TODO Auto-generated method stub |
There was a problem hiding this comment.
Please remove this line.
| } | ||
| }; | ||
| protected Class<? extends OperationHandlerProvider> bindOperatioHandlerProvider() { | ||
| // TODO Auto-generated method stub |
There was a problem hiding this comment.
Please remove this line.
tortmayr
force-pushed
the
tortmayr/di-refactor
branch
from
4e19ae0 to
60355b1
Compare
tortmayr
added a commit
that referenced
this pull request
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires eclipse-glsp/glsp-server#37