Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading OpenJFX-Modules 11 in OSGi #217

Closed
tomsontom opened this issue May 3, 2018 · 5 comments
Closed

Loading OpenJFX-Modules 11 in OSGi #217

tomsontom opened this issue May 3, 2018 · 5 comments
Assignees
Milestone

Comments

@tomsontom
Copy link
Contributor

OpenJFX-Modules will not be shipped in the JRE but need to be added to module-path. We need to find a strategy to install the OpenFX-Binaries at runtime.

@tomsontom tomsontom added this to the 4.0.0 milestone May 3, 2018
@tomsontom tomsontom self-assigned this May 3, 2018
@tomsontom tomsontom changed the title Loading OpenJFX-Modules in OSGi Loading OpenJFX-Modules 11 in OSGi May 4, 2018
@klaraward
Copy link

Early access builds of OpenJFX- http://jdk.java.net/openjfx/

@eliasvasylenko
Copy link
Contributor

The first Maven snapshots are now available: http://mail.openjdk.java.net/pipermail/openjfx-dev/2018-July/022088.html

They are not shipped with OSGi metadata. In the (likely?) event that they're not interested in adding it, I assume it's just a matter of wrapping and republishing as a p2 artefact somewhere?

@tomsontom
Copy link
Contributor Author

That won't help! JavaFX is designed to run on the module-path, while it might work on the classpath there's no guarantee that it will in future.

@eliasvasylenko
Copy link
Contributor

Surely this is true of any external dependencies packaged as modules. But until perhaps the next OSGi release specifies a strategy for JPMS interoperation, or unless Eclipse already has a general strategy planned for this, what choice is there?

Recreating the module metadata as bundle metadata will probably work. And if it stops working at some point in the future, that can be dealt with in the future, no?

@tomsontom
Copy link
Contributor Author

We are already spinning up a virtual layer for swtfx.jar I think that's the way to go for plain OpenJFX on Java 11 onwards as well.

@tomsontom tomsontom modified the milestones: 4.0.0, 3.4.0 Aug 4, 2018
tomsontom added a commit that referenced this issue Aug 4, 2018
* added support to load modules from a directory
* added support to load modules from bundles

fixes #217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants