Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FXClassLoader doesn't work properly for Java 10 #215

Closed
qtdzz opened this issue May 2, 2018 · 2 comments
Closed

FXClassLoader doesn't work properly for Java 10 #215

qtdzz opened this issue May 2, 2018 · 2 comments
Milestone
3.3.0

Comments

@qtdzz
Copy link

qtdzz commented May 2, 2018

When using Java 10, javafx.embed is not hooked correctly as it does in Java 9. It throws

Unable to locate JavaFX. Please make sure you have a JDK with JavaFX installed eg on Linux you require an Oracle JDK

I think the problem is possibly from this https://github.com/eclipse/efxclipse-rt/blob/master/modules/core/org.eclipse.fx.osgi/src/main/java/org/eclipse/fx/osgi/fxloader/FXClassLoader.java#L48
@tomsontom tomsontom added this to the 3.3.0 milestone May 2, 2018
@tomsontom tomsontom self-assigned this May 2, 2018
@tomsontom
Copy link
Contributor

I've put this now on 3.3.0 although I can not guarantee that I'll have the cycles to fix it.

@qtdzz qtdzz mentioned this issue May 4, 2018
Closed
tomsontom added a commit that referenced this issue May 4, 2018
@tomsontom
fixes #215
e1321f7
@tomsontom
Copy link
Contributor

@qtdzz you might be interested in #217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

No branches or pull requests
2 participants
@tomsontom @qtdzz