Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more validation on the UI field: artifactId #150

Closed
IvoNet opened this issue Nov 7, 2022 · 3 comments
Closed

Add more validation on the UI field: artifactId #150

IvoNet opened this issue Nov 7, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request low-priority Low priority issue

Comments

@IvoNet
Copy link
Contributor

IvoNet commented Nov 7, 2022

Add validation to the artifactId field in the starter UI

ArtifactId should only allow:

  • lowercase names
  • names starting with [a-z]
  • hyphens ('-') but no underscores ('_')
  • no spaces
  • etc.

see also here: guide-naming-conventions

@rokon12 rokon12 self-assigned this Jan 1, 2023
@m-reza-rahman m-reza-rahman added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed low-priority Low priority issue labels Mar 17, 2023
@m-reza-rahman m-reza-rahman removed good first issue Good for newcomers help wanted Extra attention is needed labels Oct 6, 2023
@geziefer
Copy link
Contributor

I could do this together with #274

@m-reza-rahman m-reza-rahman assigned geziefer and unassigned rokon12 Nov 29, 2023
@geziefer
Copy link
Contributor

groupId satisfies java package naming which must start with a letter followes by any number of letters, digits or underscore and then any number of similar parts separated by dot - the following regex was used: "^[a-zA-Z][a-zA-Z0-9_](.[a-zA-Z][a-zA-Z0-9_])*$"
This was addressed in PR #292

m-reza-rahman pushed a commit that referenced this issue May 14, 2024
Add groupId and artifactId to UI including validation (partly #274, #149, #150)
@m-reza-rahman
Copy link
Contributor

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low-priority Low priority issue
Projects
None yet
Development

No branches or pull requests

4 participants