Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more validation on the UI field: version #151

Closed
IvoNet opened this issue Nov 7, 2022 · 11 comments
Closed

Add more validation on the UI field: version #151

IvoNet opened this issue Nov 7, 2022 · 11 comments
Assignees
Labels
enhancement New feature or request low-priority Low priority issue

Comments

@IvoNet
Copy link
Contributor

IvoNet commented Nov 7, 2022

Add validation to the version field in the starter UI

'version' should only allow e.g.:

  • 1.0.0-SNAPSHOT
  • 1.0.0
  • 1.0
  • 1.2.999-SNAPSHOT
  • 1.0.0-RC2

see also here: guide-naming-conventions

Default value should be 1.0.0-SNAPSHOT (as it already is)

@rokon12
Copy link
Contributor

rokon12 commented Jan 1, 2023

Do we use a regex for this? or use a dropdown of this fixed value.

@rokon12 rokon12 self-assigned this Jan 1, 2023
@rokon12
Copy link
Contributor

rokon12 commented Jan 1, 2023

Example -

^(?:[1-9]\d*)(?:\.(?:0|[1-9]\d*))*(?:-(?:SNAPSHOT|RC\d+))?$

@m-reza-rahman
Copy link
Contributor

Yes, a regular expression should be good.

@jeyvison
Copy link
Contributor

jeyvison commented Jan 1, 2023

I'm not sure if we should add a validation for this.

Doing so will force the user to use the pattern we defined instead make it free for them use the version field as they see fit. After all, the naming guide is a convention, not a rule.

@m-reza-rahman
Copy link
Contributor

Agreed. I think this is a very low priority we should look at much later.

@rokon12
Copy link
Contributor

rokon12 commented Mar 17, 2023

We can mark this one, #150 and #149 as low-priority or remove for now.

@m-reza-rahman m-reza-rahman added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed low-priority Low priority issue labels Mar 17, 2023
@m-reza-rahman m-reza-rahman removed good first issue Good for newcomers help wanted Extra attention is needed labels Oct 6, 2023
@geziefer
Copy link
Contributor

I could do this together with #274

@m-reza-rahman m-reza-rahman assigned geziefer and unassigned rokon12 Nov 29, 2023
@geziefer
Copy link
Contributor

@m-reza-rahman For clarification: Should the 3 validation tickets apply to UI only or already be incorporated in archetype?
My personal suggestion is to go with UI only, as this is our provided convenient access to the archetype, but if someone uses purely the archetype, he could input whatever he wants as Maven coordinates.

@m-reza-rahman
Copy link
Contributor

I think that’s fine. To be honest I don’t think these validations are super important. They are a nice to have.

@geziefer
Copy link
Contributor

This ticket should be closed as "won't do".
It was already agreed when enhancing the UI that version is not necessarry. It is unlikely, that the user needs to have something different than the default and is able to change this very easy without any effect to other files than the pom.

@m-reza-rahman
Copy link
Contributor

Agreed. Closing for now.

@m-reza-rahman m-reza-rahman closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low-priority Low priority issue
Projects
None yet
Development

No branches or pull requests

5 participants