Update postgresql to multi-arch to support s390x #16903
Conversation
Signed-off-by: Shahid Shaikh <shahid@us.ibm.com>
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
che-bot
added
status/code-review
| @@ -6,7 +6,7 @@ | |||
| # SPDX-License-Identifier: EPL-2.0 | |||
| # | |||
|
|
|||
| FROM centos/postgresql-96-centos7 | |||
| FROM registry.access.redhat.com/rhscl/postgresql-10-rhel7 | |||
There was a problem hiding this comment.
We need to make sure that the upgrade for existed installation from postgresql 9.6 to 10 is working.
Have you tested it?
There was a problem hiding this comment.
does it work with docker.io/postgres:9.6.17-alpine or docker.io/postgres:9.6.17 (debian based)
(no bump of the postgres version) ?
There was a problem hiding this comment.
@skabashnyuk I must confess that this use case skipped from my mind. So if updating postgresql version is causing other overheads, I'll revert the changes for 9.6.17 as @benoitf has suggested.
@benoitf I am able to build che-postgres docker image using both variants you suggested i.e. docker.io/postgres:9.6.17-alpine and docker.io/postgres:9.6.17. Let me know your preference for the base image. Will update the PR with same.
There was a problem hiding this comment.
@shahidhs-ibm there are quite a few scripts that make PostgreSQL installation possible https://github.com/eclipse/che/tree/master/dockerfiles/postgres can you check if they compatible with docker.io/postgres:9.6.17?
CC @tolusha
There was a problem hiding this comment.
@skabashnyuk The che-postgres docker image built with docker.io/postgres:9.6.17-alpine is not compatible with the scripts. The centos Vs alpine postgres images are built with different methodology which makes them incompatible.
This best possible approach is to extend postgresql-96 docker image support to s390x. We have raised an issue for this.
There was a problem hiding this comment.
@tolusha @nickboldt @benoitf Your updates?
There was a problem hiding this comment.
The best way if we find (build ?) centos/postgresql-96-centos7 image for s390x platform
Otherwise we have to perform a lot of tests to be sure the previous deployments work well.
BTW codeready uses registry.redhat.io/rhscl/postgresql-96-rhel7:1-47
There was a problem hiding this comment.
@tolusha Thanks for the update. Yes the best way will be to get the image from centos but we haven't got any response from community on issue we raised for code contribution. The registry.redhat.io/rhscl/postgresql-96-rhel7:1-47 which is used by CRW is unfortunately not multi-arch, so we don't have many options left other than using registry.redhat.io/rhel8/postgresql-96 or adding multi-arch support to centos/postgresql-96-centos7.
@nickboldt Could you please provide your inputs on using RH subscription image for postgres? Will it be OK?
There was a problem hiding this comment.
Note that registry.redhat.io/rhscl/postgresql-96-rhel7:1-47 is single arch, amd64.
We switched to registry.redhat.io/rhel8/postgresql-96:1 to get support for Z and Power (it also includes arm).
For future reference, you can check the arches in a given image like this:
$➔ skopeo inspect docker://registry.redhat.io/rhel8/postgresql-96:1 --raw \
| yq '.manifests[].platform.architecture' -r
amd64
arm64
ppc64le
s390x
I don't believe we can (yet) use authenticated RHEC images for Che builds. See #18292 (comment) for ongoing discussion.
|
[ci-build] |
|
Given that there's been talk of removing postgres db dependency from Che 7 entirely, I wonder if this change will ever be merged. |
|
Stalled since May 2020, with no viable change to move to a postgres 9.6 base image. So... closing. Please reopen if that's an error, or submit a new PR. |
Signed-off-by: Shahid Shaikh shahid@us.ibm.com
What does this PR do?
Update the base image to
postgresql-10-rhel7which supports multi-arch. Thus providing support to variety of architectures including s390x.What issues does this PR fix or reference?
This PR is part of this initiative.
Release Notes
Docs PR