Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the new PostgreSQL #20246

Closed
8 tasks done
Tracked by #20218
skabashnyuk opened this issue Aug 4, 2021 · 7 comments
Closed
8 tasks done
Tracked by #20218

Migrate to the new PostgreSQL #20246

skabashnyuk opened this issue Aug 4, 2021 · 7 comments
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/che-server kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed.
Milestone

Comments

@skabashnyuk
Copy link
Contributor

skabashnyuk commented Aug 4, 2021

Is your task related to a problem? Please describe.

The final Release of PostgreSQL 9.6 should be November 11, 2021.
We use it as a database for che-server and keycloak.
We need to migrate to a more recent common version.

Describe the solution you'd like

  • Figure out the latest PostgreSQL we need.
  • Pick docker image
  • Push docker image to http://quay.io/
  • Provide a strategy for new installations
  • Provide a strategy for old installations

Describe alternatives you've considered

n/a

Imeplentation

Additional context

@skabashnyuk skabashnyuk added the kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. label Aug 4, 2021
@skabashnyuk skabashnyuk changed the title Migrate to the new PosgreSQL Migrate to the new PostgreSQL Aug 4, 2021
@skabashnyuk skabashnyuk added area/che-server area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/install Issues related to installation, including offline/air gap and initial setup labels Aug 4, 2021
@skabashnyuk
Copy link
Contributor Author

Looks like docker.io/postgres:13.3-alpine3.14 upstream and registry.redhat.io/rhel8/postgresql-13 for downstream is our choice. Have an agreement from @benoitf and @nickboldt

@tolusha
Copy link
Contributor

tolusha commented Aug 4, 2021

https://github.com/eclipse-che/che-server/tree/main/dockerfiles/postgres
I think it is used in helmcharts

@skabashnyuk
Copy link
Contributor Author

https://github.com/eclipse-che/che-server/tree/main/dockerfiles/postgres
I think it is used in helmcharts

We definitely need to use the same image across all possible installation ways.

@xbaran4
Copy link
Contributor

xbaran4 commented Aug 10, 2021

Is there a possibility we could use centos/postgresql-13-centos7 in https://github.com/eclipse-che/che-server/blob/72bfc85436022bc87aad109829411ef7f9b48663/dockerfiles/postgres/Dockerfile#L9 ?

Since it is pretty much one line change and all the configuration stays the same, so everything works out of the box.
CC @nickboldt @skabashnyuk @benoitf

@skabashnyuk
Copy link
Contributor Author

Is there a possibility we could use centos/postgresql-13-centos7 in https://github.com/eclipse-che/che-server/blob/72bfc85436022bc87aad109829411ef7f9b48663/dockerfiles/postgres/Dockerfile#L9 ?

For testing - yes. I see only "linux/amd64" arch which might be problematic.

@xbaran4
Copy link
Contributor

xbaran4 commented Aug 18, 2021

Postgres 13 alpine and buster images have different configuration from the centos and rhel prostgres 9.6 we use now (different env variables, different directory layout, different entrypoint scripts and possibly more).

If we decided for alpine or buster in Che, we would need to adapt che operator for the new image and that would mean having different implementations in che operator for upstream and downstream.

So we recommend to go with centos/postgresql-13-centos7 for upstream and rhel8/postgresql-13 for downstream, since they are sharing configuration.

@nickboldt nickboldt added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Aug 19, 2021
@nickboldt
Copy link
Contributor

Downstream issue: https://issues.redhat.com/browse/CRW-2180

@tolusha tolusha removed the area/install Issues related to installation, including offline/air gap and initial setup label Sep 21, 2021
@tolusha tolusha added this to the 7.37 milestone Sep 22, 2021
@l0rd l0rd removed the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/che-server kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed.
Projects
None yet
Development

No branches or pull requests

5 participants