Allow multiple devfile registries #16399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julie Stalley <julie_stalley@uk.ibm.com> Cosigned-off-by: Toby Corbin <corbint@uk.ibm.com>
sleshchenko
requested review from
ashumilova,
benoitf,
l0rd,
nickboldt and
rhopp
as code owners
che-bot
added
status/code-review
This was referenced Mar 19, 2020
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
|
So as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows multiple devfile registries to be specified as a space separated list, for example in values.yml we can have:
The registry location is then stored so that the devfile can be read from the correct location.
The initial implementation is taken from #16390, #14059
It contains only Dashboard related changes. Che Server and Che Operator changes will be made separately.
What issues does this PR fix or reference?
Fixes #13961
Release Notes
Docs PR