Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple devfile registries to be added to che #13961

Closed
tobespc opened this issue Jul 23, 2019 · 6 comments · Fixed by eclipse-che/che-dashboard#5
Closed

Allow multiple devfile registries to be added to che #13961

tobespc opened this issue Jul 23, 2019 · 6 comments · Fixed by eclipse-che/che-dashboard#5
Assignees
Labels
area/dashboard area/devfile-registry kind/enhancement A feature request - must adhere to the feature request template.
Milestone

Comments

@tobespc
Copy link
Contributor

tobespc commented Jul 23, 2019

Is your enhancement related to a problem? Please describe.

At the moment, the dashboard references a single location from where it gets it devfiles from. In our case, we would like to add additional devfile registries so that we can can deploy che with the blessed set and also our additional set.

Describe the solution you'd like

In che.properties, the current implementation sets

che.workspace.devfile_registry_url=https://che-devfile-registry.openshift.io/

This could be enhanced to take multiple urls which would then be processed in devfile-registry.factory.js when fetching the devfile

Describe alternatives you've considered

Another option could be having the existing https://che-devfile-registry.openshift.io/ pull in other repositories but this would be clumsy imo and hard to maintain

@tobespc tobespc added the kind/enhancement A feature request - must adhere to the feature request template. label Jul 23, 2019
@tobespc
Copy link
Contributor Author

tobespc commented Jul 23, 2019

This is something my team is working on and, providing you agree with the enhancement, will put a PR asap with a solution

@nickboldt
Copy link
Contributor

FYI @slemeur @l0rd this is the contribution from IBM we talked about a couple weeks ago. PR coming soon! Setting fixversion of 7.1 for now but if you feel this is urgent for 7.0, feel free to change.

cc: @rhopp @tsmaeder re: triage.

@slemeur
Copy link
Contributor

slemeur commented Aug 2, 2019

@skabashnyuk : Please check the PR as soon as 7.0 is released

@skabashnyuk
Copy link
Contributor

@slemeur pr looks ok for me. However, since changes are only on the dashboard side it's better that is someone familiar with it can approve it.

@slemeur
Copy link
Contributor

slemeur commented Aug 8, 2019

@evidolob + @benoitf : Could you please review?

@nickboldt
Copy link
Contributor

nickboldt commented Sep 30, 2019

seems the above pr was replaced by #14059 which has some failing flaky ci tests and can't be merged due to conflict w/ master branch.

2 months later... :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment